RESOLVED FIXED 94871
[Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests 
https://bugs.webkit.org/show_bug.cgi?id=94871
Summary [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
Julien Chaffraix
Reported 2012-08-23 16:50:52 PDT
Bug 94562 landed without enabling the CString test for Chromium due to some failures on the EWS. I tried to reproduce the failures but couldn't, which matches Benjamin's experience. I did find a build breakage though related to the #include chain (not sure why no other platform complained). Let's fix Chromium and add this test!
Attachments
Proposed change: enable CString on Chromium and fix the debug build. (2.33 KB, patch)
2012-08-23 17:03 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Better proposed change: enable all the Strings unit tests \o/ (2.87 KB, patch)
2012-08-23 17:40 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Patch for the EWS / landing. (2.88 KB, patch)
2012-08-23 18:19 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-08-23 16:57:45 PDT
The other String tests were also skipped on Chromium, let's enable everything if possible.
Julien Chaffraix
Comment 2 2012-08-23 17:03:49 PDT
Created attachment 160284 [details] Proposed change: enable CString on Chromium and fix the debug build.
Julien Chaffraix
Comment 3 2012-08-23 17:04:17 PDT
Comment on attachment 160284 [details] Proposed change: enable CString on Chromium and fix the debug build. OK, let's do it.
Julien Chaffraix
Comment 4 2012-08-23 17:40:19 PDT
Created attachment 160294 [details] Better proposed change: enable all the Strings unit tests \o/
Benjamin Poulain
Comment 5 2012-08-23 17:45:08 PDT
Comment on attachment 160294 [details] Better proposed change: enable all the Strings unit tests \o/ Thanks a lot for finding the problem.
Benjamin Poulain
Comment 6 2012-08-23 17:58:02 PDT
Comment on attachment 160294 [details] Better proposed change: enable all the Strings unit tests \o/ Looks like r126509 got in the way :(
Julien Chaffraix
Comment 7 2012-08-23 18:19:18 PDT
Created attachment 160302 [details] Patch for the EWS / landing.
WebKit Review Bot
Comment 8 2012-08-23 20:02:48 PDT
Comment on attachment 160302 [details] Patch for the EWS / landing. Clearing flags on attachment: 160302 Committed r126530: <http://trac.webkit.org/changeset/126530>
WebKit Review Bot
Comment 9 2012-08-23 20:02:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.