RESOLVED FIXED 71312
until use_skia=1 by default on mac, default port is chromium-cg-mac 
https://bugs.webkit.org/show_bug.cgi?id=71312
Summary until use_skia=1 by default on mac, default port is chromium-cg-mac
epoger
Reported 2011-11-01 13:03:05 PDT
Until we finally resolve http://code.google.com/p/chromium/issues/detail?id=101731 ('re-enable use_skia by default'), rniwa has noted that we should change the default port for layout_tests on mac back to chromium-cg-mac. Otherwise, results will be compared against Skia baselines, even though the code is build with CG instead of Skia.
Attachments
Patch (6.12 KB, patch)
2011-11-01 13:06 PDT, epoger 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
epoger
Comment 1 2011-11-01 13:06:10 PDT
Created attachment 113206 [details] Patch
epoger
Comment 2 2011-11-01 13:09:39 PDT
This patch reverts elements of *both* of the following changes, which should have been made together in the first place: http://trac.webkit.org/changeset/95850 (changed default CPU port for mac from chromium-cg-mac to chromium-mac) http://trac.webkit.org/changeset/98992 (changed default GPU port for mac from chromium-gpu-cg-mac to chromium-gpu-mac) Once we set use_skia=1 by default, we should revert this patch.
Adam Barth
Comment 3 2011-11-01 13:18:45 PDT
I'm confused. I thought we were enabling Skia by default Real Soon Now (tm).
epoger
Comment 4 2011-11-01 13:22:23 PDT
(In reply to comment #3) > I'm confused. I thought we were enabling Skia by default Real Soon Now (tm). See http://code.google.com/p/chromium/issues/detail?id=101731 ... I made that change this morning, but it caused a significant performance regression so I backed it out. This patch will help deconfuse other developers (hopefully) by making the default layout_tests port match the version that gets built.
Adam Barth
Comment 5 2011-11-01 13:23:04 PDT
Comment on attachment 113206 [details] Patch Ah thanks.
epoger
Comment 6 2011-11-01 13:33:32 PDT
I will commit this tomorrow morning so I can keep an eye on things...
WebKit Review Bot
Comment 7 2011-11-02 09:28:00 PDT
Comment on attachment 113206 [details] Patch Clearing flags on attachment: 113206 Committed r99068: <http://trac.webkit.org/changeset/99068>
WebKit Review Bot
Comment 8 2011-11-02 09:28:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.