Created attachment 86990 [details] Patch

Comment on attachment 86990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=86990&action=review > Tools/DumpRenderTree/LayoutTestController.cpp:408 > + JSRetainPtr<JSStringRef> originUrl(Adopt, JSValueToStringCopy(context, arguments[0], exception)); s/Url/URL/. > LayoutTests/http/tests/appcache/origin-usage.html:5 > +var drtUrl = "http://127.0.0.1:8000"; You only use this constant sometimes, so I'm not sure if it helps at all.

Attachment 86990 [details] did not build on win: Build output: http://queues.webkit.org/results/8243752

Created attachment 86997 [details] Patch

Comment on attachment 86997 [details] Patch Rejecting attachment 86997 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8255523

Looks like the commit queue had a network-related issue, and c-'d the patch.

Comment on attachment 86997 [details] Patch Rejecting attachment 86997 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'bu..." exit_code: 2 Last 500 characters of output: ........................................ traversal ...................... traversal/hixie-node-iterator .......... userscripts ............... webarchive ..................... webarchive/loading .... http/tests/appcache ........................................... http/tests/appcache/origin-usage.html -> failed Exiting early after 1 failures. 22032 tests run. 545.80s total testing time 22031 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 14 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8268325

Created attachment 93039 [details] Patch Revised description of test 7 to clearly indicate its dependence on test 6

Comment on attachment 93039 [details] Patch Oops! Patch for wrong bug!

Created attachment 93054 [details] Patch This patch is identical to the one Alexey r+ and c+, with the only difference being the layout test checking for a byte range instead of a precise byte number, since size can vary on the order of 10 bytes.

Created attachment 93055 [details] Patch This patch is identical to the one Alexey r+ and c+, with the only difference being the layout test checking for a byte range instead of a precise byte number, since size can vary on the order of 10 bytes.

The commit-queue encountered the following flaky tests while processing attachment 93055 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) The commit-queue is continuing to process your patch.

Comment on attachment 93055 [details] Patch Clearing flags on attachment: 93055 Committed r86204: <http://trac.webkit.org/changeset/86204>

All reviewed patches have been landed. Closing bug.