CLOSED FIXED 52524
fast/dom/Range/range-clone-contents.html fails only on Windows 
https://bugs.webkit.org/show_bug.cgi?id=52524
Summary fast/dom/Range/range-clone-contents.html fails only on Windows
David Kilzer (:ddkilzer)
Reported 2011-01-15 18:07:22 PST
LayoutTests/fast/dom/Range/range-clone-contents.html only fails on Windows bots. It would be interesting to know if disabling optimization on WebCore/dom/Range.cpp affects the results of the test. The Range::processContents() method reuses a lot of variables, also shadows many variables, and uses multiple variables within for() loop conditions.
Attachments
Patch to try (4.60 KB, patch)
2011-01-16 14:48 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Unskip the test (1.21 KB, patch)
2011-01-17 11:29 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2011-01-15 18:15:44 PST
Added the test to the Windows skip list: Committed r75889. <http://trac.webkit.org/changeset/75889>
David Kilzer (:ddkilzer)
Comment 2 2011-01-15 18:17:48 PST
<rdar://problem/8870569>
David Kilzer (:ddkilzer)
Comment 3 2011-01-16 06:45:04 PST
Brian/Adam: Are there any known issues where DOMAllInOne.cpp isn't always rebuilt properly for Windows if one of its constituent files is changed?
Adele Peterson
Comment 4 2011-01-16 11:55:10 PST
Does anyone on Windows see this failure in their local build?
David Kilzer (:ddkilzer)
Comment 5 2011-01-16 14:48:30 PST
Created attachment 79114 [details] Patch to try Patch to try if there is a codegen issue with MSVC compiler.
Adam Roben (:aroben)
Comment 6 2011-01-17 05:36:41 PST
(In reply to comment #3) > Brian/Adam: Are there any known issues where DOMAllInOne.cpp isn't always rebuilt properly for Windows if one of its constituent files is changed? I don't know of any such issues.
Adam Roben (:aroben)
Comment 7 2011-01-17 05:37:04 PST
A link to the failure diff would be handy.
David Kilzer (:ddkilzer)
Comment 8 2011-01-17 07:53:52 PST
(In reply to comment #7) > A link to the failure diff would be handy. Here are links to the failure diffs from Bug 52512 Comment #7: Windows 7 Release bot: <http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r75882%20(8257)/fast/dom/Range/range-clone-contents-pretty-diff.html> Windows XP Debug bot: <http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r75882%20(24216)/fast/dom/Range/range-clone-contents-pretty-diff.html>
Adam Roben (:aroben)
Comment 9 2011-01-17 08:11:37 PST
(In reply to comment #8) > (In reply to comment #7) > > A link to the failure diff would be handy. > > Here are links to the failure diffs from Bug 52512 Comment #7: Thanks! FYI, our standard procedure in cases like this (where the test is just failing, as opposed to crashing or timing out) is to check in platform-specific results that reflect the current behavior, rather than skipping the test.
David Kilzer (:ddkilzer)
Comment 11 2011-01-17 11:04:33 PST
A local Release build of WebKit r75949 on Windows XP shows that fast/dom/Range/range-clone-contents.html passes. This appears to be an issue with needing a clean build on the Windows buildbots. However, I'll wait for independent verification from another source before removing the test from the Skipped list.
David Kilzer (:ddkilzer)
Comment 12 2011-01-17 11:29:40 PST
Created attachment 79192 [details] Unskip the test
WebKit Commit Bot
Comment 13 2011-01-17 13:17:04 PST
Comment on attachment 79192 [details] Unskip the test Clearing flags on attachment: 79192 Committed r75970: <http://trac.webkit.org/changeset/75970>
WebKit Commit Bot
Comment 14 2011-01-17 13:17:09 PST
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 15 2011-01-17 14:05:50 PST
(In reply to comment #13) > (From update of attachment 79192 [details]) > Clearing flags on attachment: 79192 > > Committed r75970: <http://trac.webkit.org/changeset/75970> Windows 7 Release tests for r75970: <http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/8298> Windows XP Debug tests for r75970: <http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/24245> The new test now passes.
Note You need to log in before you can comment on or make changes to this bug.