RESOLVED FIXED 238504
Move AuxiliaryProcess::createIPCConnectionPair to IPC::Connection 
https://bugs.webkit.org/show_bug.cgi?id=238504
Summary Move AuxiliaryProcess::createIPCConnectionPair to IPC::Connection
Kimmo Kinnunen
Reported 2022-03-29 07:00:41 PDT
Move AuxiliaryProcess::createIPCConnectionPair to IPC::Connection
Attachments
Patch (16.18 KB, patch)
2022-03-29 07:06 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.00 KB, patch)
2022-03-29 07:40 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.03 KB, patch)
2022-03-29 09:34 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-03-29 07:06:23 PDT
Created attachment 456022 [details] Patch
Kimmo Kinnunen
Comment 2 2022-03-29 07:40:36 PDT
Created attachment 456024 [details] Patch
Kimmo Kinnunen
Comment 3 2022-03-29 07:47:59 PDT
Comment on attachment 456024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456024&action=review > Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:105 > + m_backendConnection = IPC::Connection::createServerConnection(connectionIdentifiers->server, *this); In this function, before code reuse it - created the port - set the MACH_MSG_TYPE_MAKE_SEND right - sent the port right with MACH_MSG_TYPE_MOVE_SEND Attachment disposition After code reuse: - created the port - sent the port right with MACH_MSG_TYPE_MAKE_SEND Attachment disposition I think these two should be equivalent?
Kimmo Kinnunen
Comment 4 2022-03-29 09:34:58 PDT
Created attachment 456032 [details] Patch
Chris Dumez
Comment 5 2022-03-29 11:25:46 PDT
Comment on attachment 456032 [details] Patch r=me
EWS
Comment 6 2022-03-30 02:49:16 PDT
Committed r292102 (249022@main): <https://commits.webkit.org/249022@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456032 [details].
Radar WebKit Bug Importer
Comment 7 2022-03-30 02:50:16 PDT
<rdar://problem/91034263>
Note You need to log in before you can comment on or make changes to this bug.