RESOLVED FIXED216333
[webkitscmpy] Add tags, branches queries on local repositories 
https://bugs.webkit.org/show_bug.cgi?id=216333
Summary [webkitscmpy] Add tags, branches queries on local repositories
Jonathan Bedard
Reported 2020-09-09 16:20:08 PDT
Add a set of functions to list all branches and tags for a local repository.
Attachments
Patch (11.55 KB, patch)
2020-09-09 16:34 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (11.64 KB, patch)
2020-09-09 22:35 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-09-09 16:20:44 PDT
<rdar://problem/68603047>
Jonathan Bedard
Comment 2 2020-09-09 16:34:52 PDT
Created attachment 408384 [details] Patch
dewei_zhu
Comment 3 2020-09-09 17:16:19 PDT
Comment on attachment 408384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408384&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:60 > + with mocks.local.Git(self.path, branches=('branch-1', 'branch-2')): > + self.assertEqual( > + local.Git(self.path).branches, > + ['main', 'branch-1', 'branch-2'], > + ) Maybe add `remotes/origin/HEAD -> origin/main`to the test case and expect it to be excluded?
dewei_zhu
Comment 4 2020-09-09 17:17:52 PDT
Comment on attachment 408384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408384&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:60 >> + ) > > Maybe add `remotes/origin/HEAD -> origin/main`to the test case and expect it to be excluded? Maybe also include `* current-bench` to expect it to be 'current-branch' in the output.
Jonathan Bedard
Comment 5 2020-09-09 22:35:44 PDT
Created attachment 408413 [details] Patch
EWS
Comment 6 2020-09-10 08:28:49 PDT
Committed r266826: <https://trac.webkit.org/changeset/266826> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408413 [details].
Note You need to log in before you can comment on or make changes to this bug.