RESOLVED FIXED 206421
[EWS] Print disk space usage for windows bots 
https://bugs.webkit.org/show_bug.cgi?id=206421
Summary [EWS] Print disk space usage for windows bots
Aakash Jain
Reported 2020-01-17 09:19:43 PST
We added build-step to print bot configuration in EWS in https://trac.webkit.org/changeset/240680/webkit On windows, we should also print disk space usage. It would help in debugging disk space issues.
Attachments
Patch (1.77 KB, patch)
2020-01-17 09:24 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (2.43 KB, patch)
2020-01-17 09:34 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-01-17 09:24:47 PST
Created attachment 388046 [details] Patch
Aakash Jain
Comment 3 2020-01-17 09:34:12 PST
Created attachment 388048 [details] Patch
Jonathan Bedard
Comment 4 2020-01-17 09:37:28 PST
Comment on attachment 388048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388048&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1888 > + command_list_win = [['df', '-hl']] Shouldn't this go into command_list_generic? Do we have a 4th class of machines?
Aakash Jain
Comment 5 2020-01-17 09:40:45 PST
Comment on attachment 388048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388048&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:1888 >> + command_list_win = [['df', '-hl']] > > Shouldn't this go into command_list_generic? Do we have a 4th class of machines? Yeah, the 4th category is wincairo. We don't want to run this command on wincairo since I believe wincairo doesn't use cygwin and windows doesn't have df command.
WebKit Commit Bot
Comment 6 2020-01-17 16:32:18 PST
The commit-queue encountered the following flaky tests while processing attachment 388048 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-01-17 16:32:54 PST
Comment on attachment 388048 [details] Patch Clearing flags on attachment: 388048 Committed r254777: <https://trac.webkit.org/changeset/254777>
WebKit Commit Bot
Comment 8 2020-01-17 16:32:56 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-01-17 16:33:15 PST
<rdar://problem/58700332>
Aakash Jain
Comment 10 2020-01-18 07:19:38 PST
Deployed on the production server. Working fine, e.g.: https://ews-build.webkit.org/#/builders/10/builds/4263/steps/2/logs/stdio
Note You need to log in before you can comment on or make changes to this bug.