RESOLVED FIXED 204723
[LFC][IFC] Add support for word-spacing property 
https://bugs.webkit.org/show_bug.cgi?id=204723
Summary [LFC][IFC] Add support for word-spacing property
alan
Reported 2019-11-30 18:37:26 PST
ssia
Attachments
Patch (3.26 KB, patch)
2019-11-30 18:42 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-30 18:37:47 PST
<rdar://problem/57541871>
alan
Comment 2 2019-11-30 18:42:36 PST
Created attachment 384564 [details] Patch
Antti Koivisto
Comment 3 2019-12-01 00:55:17 PST
Comment on attachment 384564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384564&action=review No tests enabled? > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:714 > + itemRunWidth = std::max({ }, itemRunWidth); I think 0_lu would read better than { }
Antti Koivisto
Comment 4 2019-12-01 00:56:37 PST
Comment on attachment 384564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384564&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:50 > + auto wordSpacing = inlineTextItem.isWhitespace() ? LayoutUnit(inlineTextItem.style().fontCascade().wordSpacing()) : LayoutUnit(); 0_lu would work here too
alan
Comment 5 2019-12-01 07:27:13 PST
Committed r252967: <https://trac.webkit.org/changeset/252967>
Note You need to log in before you can comment on or make changes to this bug.