RESOLVED FIXED 171164
[ATK] Implement support for new ARIA 1.1 values of aria-haspopup 
https://bugs.webkit.org/show_bug.cgi?id=171164
Summary [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
Joanmarie Diggs
Reported 2017-04-22 10:42:44 PDT
For ATK, support for aria-haspopup requires: 1. Add STATE_HAS_POPUP to the state set 2. Expose the value of aria-haspopup via the "haspopup" object attribute
Attachments
Patch (16.10 KB, patch)
2017-04-26 06:22 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
Patch (15.85 KB, patch)
2017-04-26 11:04 PDT, Joanmarie Diggs 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-04-22 10:43:10 PDT
<rdar://problem/31774638>
Radar WebKit Bug Importer
Comment 2 2017-04-22 10:49:37 PDT
<rdar://problem/31774659>
Joanmarie Diggs
Comment 3 2017-04-26 06:22:38 PDT
Created attachment 308239 [details] Patch
Joanmarie Diggs
Comment 4 2017-04-26 07:52:56 PDT
Comment on attachment 308239 [details] Patch Chris: Please review when you have a chance. Thanks!
chris fleizach
Comment 5 2017-04-26 10:02:21 PDT
Comment on attachment 308239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308239&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1013 > + const AtomicString& haspopup = getAttribute(aria_haspopupAttr); I think this can probably all move into AXObject.cpp and then this won't have to be virtual > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1014 > + if (equalLettersIgnoringASCIICase(haspopup, "true") should probably be hasPopup > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1032 > + return String(); should this also return "false"? > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1038 > + return !haspopup.isEmpty() && !equalLettersIgnoringASCIICase(haspopup, "false"); if ariaPopupValue() returned false instead of empty string we wouldn't also need the isEmpty check here
Joanmarie Diggs
Comment 6 2017-04-26 11:04:05 PDT
Created attachment 308269 [details] Patch
WebKit Commit Bot
Comment 7 2017-04-26 12:30:11 PDT
Comment on attachment 308269 [details] Patch Clearing flags on attachment: 308269 Committed r215821: <http://trac.webkit.org/changeset/215821>
WebKit Commit Bot
Comment 8 2017-04-26 12:30:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.