Created attachment 253130 [details] Patch

(In reply to comment #1) > Created attachment 253130 [details] > Patch There are many duplicated file removing and changes in Source/ThirdParty/ANGLE/build directory (gitignore!) which made this patch unappliable by Tools/Scripts/svn-apply. (Let me see if --force helps.) If I manage to apply the patch, I'm going to fix the cmake (EFL and GTK) build on monday morinng.

Created attachment 253206 [details] cmake patch The EFL build worked for with this patch on desktop, but I haven't checked if it works functionally.

Created attachment 253207 [details] full patch with cmake fix test for EWS

Created attachment 253208 [details] full patch with cmake fix patch for EWS, now including binary changes too

Created attachment 253230 [details] patch

This latest patch fails the following tests: fast/canvas/webgl/array-bounds-clamping.html fast/canvas/webgl/get-active-test.html fast/canvas/webgl/gl-uniform-arrays.html fast/canvas/webgl/uniform-location-length-limits.html fast/canvas/webgl/uniform-location.html webgl/1.0.2/conformance/glsl/misc/glsl-long-variable-names.html webgl/1.0.2/conformance/limits/gl-min-textures.html webgl/1.0.2/conformance/limits/gl-min-uniforms.html webgl/1.0.2/conformance/more/functions/uniformMatrixBadArgs.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/1.0.2/conformance/more/functions/uniformfArrayLen1.html webgl/1.0.2/conformance/ogles/GL/array/array_001_to_006.html webgl/1.0.2/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html webgl/1.0.2/conformance/ogles/GL/mat3/mat3_001_to_006.html webgl/1.0.2/conformance/programs/get-active-test.html webgl/1.0.2/conformance/ogles/GL/vec3/vec3_001_to_008.html webgl/1.0.2/conformance/glsl/misc/shader-with-similar-uniform-array-names.html webgl/1.0.2/conformance/glsl/misc/uniform-location-length-limits.html webgl/1.0.2/conformance/uniforms/gl-uniform-arrays.html webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html webgl/1.0.2/conformance/uniforms/uniform-default-values.html webgl/1.0.2/conformance/uniforms/uniform-location.html

ANGLE has replaced src/compiler/translator/intermediate.h with a significantly changed src/compiler/translator/Intermediate.h. svn-apply did not like this change, so I just changed src/compiler/translator/intermediate.h and left its name lower case to make the patch apply cleaner. I'm not sure why the efl and gtk bots don't like this.

Created attachment 253237 [details] patch

Created attachment 253241 [details] patch

I'll get Windows building, but otherwise I'm leaving this in your hands, Dean, to review the patch and fix the tests. Almost everything works, but there are some small quirks here and there that need addressing.

Comment on attachment 253241 [details] patch Attachment 253241 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6579111292043264 New failing tests: fast/canvas/webgl/uniform-location.html webgl/1.0.2/conformance/programs/get-active-test.html webgl/1.0.2/conformance/glsl/misc/uniform-location-length-limits.html webgl/1.0.2/conformance/more/functions/uniformfArrayLen1.html webgl/1.0.2/conformance/glsl/misc/glsl-long-variable-names.html fast/canvas/webgl/get-active-test.html webgl/1.0.2/conformance/more/functions/uniformMatrixBadArgs.html webgl/1.0.2/conformance/uniforms/uniform-default-values.html webgl/1.0.2/conformance/limits/gl-min-textures.html webgl/1.0.2/conformance/ogles/GL/array/array_001_to_006.html webgl/1.0.2/conformance/ogles/GL/mat3/mat3_001_to_006.html webgl/1.0.2/conformance/uniforms/uniform-location.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/1.0.2/conformance/ogles/GL/vec3/vec3_001_to_008.html webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html webgl/1.0.2/conformance/limits/gl-min-uniforms.html webgl/1.0.2/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html fast/canvas/webgl/array-bounds-clamping.html webgl/1.0.2/conformance/glsl/misc/shader-with-similar-uniform-array-names.html fast/canvas/webgl/uniform-location-length-limits.html fast/canvas/webgl/gl-uniform-arrays.html webgl/1.0.2/conformance/uniforms/gl-uniform-arrays.html

Created attachment 253257 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Created attachment 253258 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Created attachment 253443 [details] patch rebased after r184605

Comment on attachment 253443 [details] patch rebased after r184605 Attachment 253443 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6469802629529600 New failing tests: fast/canvas/webgl/uniform-location.html webgl/1.0.2/conformance/programs/get-active-test.html webgl/1.0.2/conformance/glsl/misc/uniform-location-length-limits.html webgl/1.0.2/conformance/more/functions/uniformfArrayLen1.html webgl/1.0.2/conformance/glsl/misc/glsl-long-variable-names.html fast/canvas/webgl/get-active-test.html webgl/1.0.2/conformance/more/functions/uniformMatrixBadArgs.html webgl/1.0.2/conformance/uniforms/uniform-default-values.html webgl/1.0.2/conformance/limits/gl-min-textures.html webgl/1.0.2/conformance/ogles/GL/array/array_001_to_006.html webgl/1.0.2/conformance/ogles/GL/mat3/mat3_001_to_006.html webgl/1.0.2/conformance/uniforms/uniform-location.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/1.0.2/conformance/ogles/GL/vec3/vec3_001_to_008.html webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html webgl/1.0.2/conformance/limits/gl-min-uniforms.html webgl/1.0.2/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html fast/canvas/webgl/array-bounds-clamping.html webgl/1.0.2/conformance/glsl/misc/shader-with-similar-uniform-array-names.html fast/canvas/webgl/uniform-location-length-limits.html fast/canvas/webgl/gl-uniform-arrays.html webgl/1.0.2/conformance/uniforms/gl-uniform-arrays.html

Created attachment 253450 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Created attachment 253451 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

any update of this bug?

No update. If you want to look into why this causes a few test failures, then go for it.

(In reply to comment #20) > No update. If you want to look into why this causes a few test failures, > then go for it. I don't have any time for fixing these failures (and not interested in it at all). I just asked it, because I didn't know if I should wait for the ANGLE update or try to fix bug145125 with the actual ANGLE.

(In reply to comment #21) > I didn't know if I should wait for the ANGLE update or try to fix bug145125 with the actual ANGLE. It would be nice if you could wait. If not, I could rebase this patch. No big deal either way.

Created attachment 255881 [details] patch

Added a few override keywords and committed to http://trac.webkit.org/changeset/186169 Windows build fix committed to https://trac.webkit.org/changeset/186172

(In reply to comment #24) > Added a few override keywords and committed to > http://trac.webkit.org/changeset/186169 > Windows build fix committed to https://trac.webkit.org/changeset/186172 It broke the WinCairo build.

(In reply to comment #25) > It broke the WinCairo build. I think the solution is to uninstall the June 2010 DirectX SDK. I'm looking into this.