WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
107471
Don't overlap test for composited scroll DIVs after scroll
https://bugs.webkit.org/show_bug.cgi?id=107471
Summary
Don't overlap test for composited scroll DIVs after scroll
Glenn Hartmann
Reported
2013-01-21 12:52:09 PST
Don't overlap test for composited scroll DIVs
Attachments
Patch
(50.66 KB, patch)
2013-01-21 13:00 PST
,
Glenn Hartmann
no flags
Details
Formatted Diff
Diff
Patch
(52.06 KB, patch)
2013-01-22 07:41 PST
,
Glenn Hartmann
no flags
Details
Formatted Diff
Diff
Patch
(51.93 KB, patch)
2013-01-22 10:27 PST
,
Glenn Hartmann
no flags
Details
Formatted Diff
Diff
Patch
(4.20 KB, patch)
2013-01-29 07:34 PST
,
Glenn Hartmann
no flags
Details
Formatted Diff
Diff
Patch for landing
(4.20 KB, patch)
2013-01-29 08:47 PST
,
Glenn Hartmann
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Glenn Hartmann
Comment 1
2013-01-21 13:00:58 PST
Created
attachment 183824
[details]
Patch
vollick
Comment 2
2013-01-22 05:47:40 PST
I think that, at least for now, it would make sense to only call updateCompositingLayers with the new enumerant if both !hasOutOfFlowPositionedDescendant and usesCompositedScrolling. If both of these are true, we can argue that a) Since we're using comp-scrolling, the composited region presented by the composited-scrolling element to other non-descendant layers doesn't change during composited scrolling (it's always the entire scroll layer), and b) Since we have no out of flow positioned descendants, the scrolling descendants all move together, so their overlap with respect to each other cannot change. So no descendants nor any non-descendants can have their overlap affected, so it's safe to skip testing.
Glenn Hartmann
Comment 3
2013-01-22 07:41:07 PST
Created
attachment 183986
[details]
Patch
WebKit Review Bot
Comment 4
2013-01-22 08:48:12 PST
Comment on
attachment 183986
[details]
Patch
Attachment 183986
[details]
did not pass chromium-ews (chromium-xvfb): Output:
http://queues.webkit.org/results/16031658
New failing tests: css3/flexbox/flexbox-overflow-auto.html compositing/geometry/limit-layer-bounds-clipping-ancestor.html fast/body-propagation/overflow/002-xhtml.xhtml compositing/overflow/automatically-opt-into-composited-scrolling.html fast/block/float/overhanging-tall-block.html css2.1/20110323/block-non-replaced-height-016.htm fast/body-propagation/overflow/003.html http/tests/eventsource/eventsource-cors-with-credentials.html compositing/overflow/overflow-scrollbar-layers.html compositing/overflow/overflow-auto-with-touch-toggle.html compositing/layer-creation/scroll-partial-update.html http/tests/inspector/search/search-in-concatenated-script.html css3/flexbox/child-overflow.html fast/body-propagation/overflow/007-declarative.xhtml compositing/geometry/limit-layer-bounds-transformed-overflow.html css3/flexbox/flexbox-baseline.html compositing/overflow/clip-content-under-overflow-controls.html fast/body-propagation/overflow/004-declarative.xhtml fast/body-propagation/overflow/002.html fast/body-propagation/overflow/003-declarative.xhtml compositing/overflow/content-gains-scrollbars.html http/tests/inspector/search/search-in-script.html fast/body-propagation/overflow/004-xhtml.xhtml http/tests/inspector/compiler-source-mapping-debug.html compositing/layer-creation/overflow-scroll-overlap.html compositing/overflow/overflow-scroll.html fast/body-propagation/overflow/004.html fast/body-propagation/overflow/003-xhtml.xhtml fast/body-propagation/overflow/007-xhtml.xhtml http/tests/inspector/resource-tree/resource-tree-reload.html
Glenn Hartmann
Comment 5
2013-01-22 10:27:58 PST
Created
attachment 184006
[details]
Patch
Glenn Hartmann
Comment 6
2013-01-29 07:34:43 PST
Created
attachment 185246
[details]
Patch
Glenn Hartmann
Comment 7
2013-01-29 08:47:05 PST
Created
attachment 185252
[details]
Patch for landing Fixed typo in changelog: changed "on-descendant" to "non-descendant".
WebKit Review Bot
Comment 8
2013-01-29 09:05:52 PST
Comment on
attachment 185252
[details]
Patch for landing Clearing flags on attachment: 185252 Committed
r141121
: <
http://trac.webkit.org/changeset/141121
>
WebKit Review Bot
Comment 9
2013-01-29 09:05:57 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug