Bug 145010

Summary:

Update ANGLE

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

ANGLE

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, buildbot, dino, gyuyoung.kim, ossy, peavo, rniwa, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

145125

Attachments:

Description	Flags
Patch	none
cmake patch	none
full patch with cmake fix	none
full patch with cmake fix	none
patch	none
patch	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-mavericks-wk2	none
Archive of layout-test-results from ews100 for mac-mavericks	none
patch rebased after r184605	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
patch	dino: review+

Alex Christensen

Reported 2015-05-14 11:19:15 PDT

In order to pass WebGL 1.0.3 tests, we need to update ANGLE. This first patch works and passes almost all of the tests. Uploading as work in progress.

Attachments
Patch (16.04 MB, patch) 2015-05-14 11:23 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
cmake patch (7.47 KB, patch) 2015-05-15 10:37 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
full patch with cmake fix (11.18 MB, patch) 2015-05-15 10:38 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
full patch with cmake fix (12.04 MB, patch) 2015-05-15 10:43 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
patch (11.19 MB, patch) 2015-05-15 15:37 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (8.94 MB, patch) 2015-05-15 16:13 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (8.94 MB, patch) 2015-05-15 17:02 PDT, Alex Christensen	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (1.06 MB, application/zip) 2015-05-15 19:50 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-mavericks (1.13 MB, application/zip) 2015-05-15 19:55 PDT, Build Bot	no flags	Details
patch rebased after r184605 (8.92 MB, patch) 2015-05-20 09:45 PDT, Alex Christensen	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (705.40 KB, application/zip) 2015-05-20 11:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (761.39 KB, application/zip) 2015-05-20 11:21 PDT, Build Bot	no flags	Details
patch (8.91 MB, patch) 2015-06-30 17:28 PDT, Alex Christensen	dino: review+	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2015-05-14 11:23:18 PDT

Created attachment 253130 [details] Patch

Csaba Osztrogonác

Comment 2 2015-05-15 09:59:49 PDT

(In reply to comment #1) > Created attachment 253130 [details] > Patch There are many duplicated file removing and changes in Source/ThirdParty/ANGLE/build directory (gitignore!) which made this patch unappliable by Tools/Scripts/svn-apply. (Let me see if --force helps.) If I manage to apply the patch, I'm going to fix the cmake (EFL and GTK) build on monday morinng.

Csaba Osztrogonác

Comment 3 2015-05-15 10:37:11 PDT

Created attachment 253206 [details] cmake patch The EFL build worked for with this patch on desktop, but I haven't checked if it works functionally.

Csaba Osztrogonác

Comment 4 2015-05-15 10:38:18 PDT

Created attachment 253207 [details] full patch with cmake fix test for EWS

Csaba Osztrogonác

Comment 5 2015-05-15 10:43:14 PDT

Created attachment 253208 [details] full patch with cmake fix patch for EWS, now including binary changes too

Alex Christensen

Comment 6 2015-05-15 15:37:29 PDT

Created attachment 253230 [details] patch

Alex Christensen

Comment 7 2015-05-15 15:45:10 PDT

This latest patch fails the following tests: fast/canvas/webgl/array-bounds-clamping.html fast/canvas/webgl/get-active-test.html fast/canvas/webgl/gl-uniform-arrays.html fast/canvas/webgl/uniform-location-length-limits.html fast/canvas/webgl/uniform-location.html webgl/1.0.2/conformance/glsl/misc/glsl-long-variable-names.html webgl/1.0.2/conformance/limits/gl-min-textures.html webgl/1.0.2/conformance/limits/gl-min-uniforms.html webgl/1.0.2/conformance/more/functions/uniformMatrixBadArgs.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/1.0.2/conformance/more/functions/uniformfArrayLen1.html webgl/1.0.2/conformance/ogles/GL/array/array_001_to_006.html webgl/1.0.2/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html webgl/1.0.2/conformance/ogles/GL/mat3/mat3_001_to_006.html webgl/1.0.2/conformance/programs/get-active-test.html webgl/1.0.2/conformance/ogles/GL/vec3/vec3_001_to_008.html webgl/1.0.2/conformance/glsl/misc/shader-with-similar-uniform-array-names.html webgl/1.0.2/conformance/glsl/misc/uniform-location-length-limits.html webgl/1.0.2/conformance/uniforms/gl-uniform-arrays.html webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html webgl/1.0.2/conformance/uniforms/uniform-default-values.html webgl/1.0.2/conformance/uniforms/uniform-location.html

Alex Christensen

Comment 8 2015-05-15 16:04:34 PDT

ANGLE has replaced src/compiler/translator/intermediate.h with a significantly changed src/compiler/translator/Intermediate.h. svn-apply did not like this change, so I just changed src/compiler/translator/intermediate.h and left its name lower case to make the patch apply cleaner. I'm not sure why the efl and gtk bots don't like this.

Alex Christensen

Comment 9 2015-05-15 16:13:42 PDT

Created attachment 253237 [details] patch

Alex Christensen

Comment 10 2015-05-15 17:02:26 PDT

Created attachment 253241 [details] patch

Alex Christensen

Comment 11 2015-05-15 17:44:09 PDT

I'll get Windows building, but otherwise I'm leaving this in your hands, Dean, to review the patch and fix the tests. Almost everything works, but there are some small quirks here and there that need addressing.

Build Bot

Comment 12 2015-05-15 19:50:35 PDT

Comment on attachment 253241 [details] patch Attachment 253241 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6579111292043264 New failing tests: fast/canvas/webgl/uniform-location.html webgl/1.0.2/conformance/programs/get-active-test.html webgl/1.0.2/conformance/glsl/misc/uniform-location-length-limits.html webgl/1.0.2/conformance/more/functions/uniformfArrayLen1.html webgl/1.0.2/conformance/glsl/misc/glsl-long-variable-names.html fast/canvas/webgl/get-active-test.html webgl/1.0.2/conformance/more/functions/uniformMatrixBadArgs.html webgl/1.0.2/conformance/uniforms/uniform-default-values.html webgl/1.0.2/conformance/limits/gl-min-textures.html webgl/1.0.2/conformance/ogles/GL/array/array_001_to_006.html webgl/1.0.2/conformance/ogles/GL/mat3/mat3_001_to_006.html webgl/1.0.2/conformance/uniforms/uniform-location.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/1.0.2/conformance/ogles/GL/vec3/vec3_001_to_008.html webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html webgl/1.0.2/conformance/limits/gl-min-uniforms.html webgl/1.0.2/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html fast/canvas/webgl/array-bounds-clamping.html webgl/1.0.2/conformance/glsl/misc/shader-with-similar-uniform-array-names.html fast/canvas/webgl/uniform-location-length-limits.html fast/canvas/webgl/gl-uniform-arrays.html webgl/1.0.2/conformance/uniforms/gl-uniform-arrays.html

Build Bot

Comment 13 2015-05-15 19:50:39 PDT

Created attachment 253257 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 14 2015-05-15 19:55:56 PDT

Created attachment 253258 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Alex Christensen

Comment 15 2015-05-20 09:45:16 PDT

Created attachment 253443 [details] patch rebased after r184605

Build Bot

Comment 16 2015-05-20 11:12:50 PDT

Comment on attachment 253443 [details] patch rebased after r184605 Attachment 253443 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6469802629529600 New failing tests: fast/canvas/webgl/uniform-location.html webgl/1.0.2/conformance/programs/get-active-test.html webgl/1.0.2/conformance/glsl/misc/uniform-location-length-limits.html webgl/1.0.2/conformance/more/functions/uniformfArrayLen1.html webgl/1.0.2/conformance/glsl/misc/glsl-long-variable-names.html fast/canvas/webgl/get-active-test.html webgl/1.0.2/conformance/more/functions/uniformMatrixBadArgs.html webgl/1.0.2/conformance/uniforms/uniform-default-values.html webgl/1.0.2/conformance/limits/gl-min-textures.html webgl/1.0.2/conformance/ogles/GL/array/array_001_to_006.html webgl/1.0.2/conformance/ogles/GL/mat3/mat3_001_to_006.html webgl/1.0.2/conformance/uniforms/uniform-location.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/1.0.2/conformance/ogles/GL/vec3/vec3_001_to_008.html webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html webgl/1.0.2/conformance/limits/gl-min-uniforms.html webgl/1.0.2/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html webgl/1.0.2/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html fast/canvas/webgl/array-bounds-clamping.html webgl/1.0.2/conformance/glsl/misc/shader-with-similar-uniform-array-names.html fast/canvas/webgl/uniform-location-length-limits.html fast/canvas/webgl/gl-uniform-arrays.html webgl/1.0.2/conformance/uniforms/gl-uniform-arrays.html

Build Bot

Comment 17 2015-05-20 11:12:53 PDT

Created attachment 253450 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 18 2015-05-20 11:21:01 PDT

Created attachment 253451 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Csaba Osztrogonác

Comment 19 2015-06-12 03:25:30 PDT

any update of this bug?

Alex Christensen

Comment 20 2015-06-15 09:56:30 PDT

No update. If you want to look into why this causes a few test failures, then go for it.

Csaba Osztrogonác

Comment 21 2015-06-16 04:02:23 PDT

(In reply to comment #20) > No update. If you want to look into why this causes a few test failures, > then go for it. I don't have any time for fixing these failures (and not interested in it at all). I just asked it, because I didn't know if I should wait for the ANGLE update or try to fix bug145125 with the actual ANGLE.

Alex Christensen

Comment 22 2015-06-16 10:03:07 PDT

(In reply to comment #21) > I didn't know if I should wait for the ANGLE update or try to fix bug145125 with the actual ANGLE. It would be nice if you could wait. If not, I could rebase this patch. No big deal either way.

Alex Christensen

Comment 23 2015-06-30 17:28:47 PDT

Created attachment 255881 [details] patch

Alex Christensen

Comment 24 2015-06-30 23:28:38 PDT

Added a few override keywords and committed to http://trac.webkit.org/changeset/186169 Windows build fix committed to https://trac.webkit.org/changeset/186172

Csaba Osztrogonác

Comment 25 2015-07-01 01:27:26 PDT

(In reply to comment #24) > Added a few override keywords and committed to > http://trac.webkit.org/changeset/186169 > Windows build fix committed to https://trac.webkit.org/changeset/186172 It broke the WinCairo build.

Alex Christensen

Comment 26 2015-07-01 14:33:30 PDT

(In reply to comment #25) > It broke the WinCairo build. I think the solution is to uninstall the June 2010 DirectX SDK. I'm looking into this.

Note You need to log in before you can comment on or make changes to this bug.