Bug 99921

Summary: [MathML] Symbol font uses greek letters for roman ones on linux and Windows
Product: WebKit Reporter: Dave Barton <dbarton>
Component: MathMLAssignee: Dave Barton <dbarton>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, bdakin, cmarcelo, davidc, donggwan.kim, eric, fred.wang, gyuyoung.kim, macpherson, menard, rakuco, spartha80, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Gaps in stretched vertical bars
none
Patch
none
Patch eric: review+

Dave Barton
Reported 2012-10-20 20:37:43 PDT
Created attachment 169784 [details] Gaps in stretched vertical bars For parts of stretched parentheses and brackets, mathml.css currently uses the Symbol font, which on linux and Windows has greek letters at roman code points. See e.g. http://build.webkit.org/results/Chromium%20Win%20Release%20%28Tests%29/r130950%20%2830524%29/mathml/presentation/attributes-actual.png or bug 38377 comment 2. To fix this, we switch to the STIXSizeOneSym font when available, including OS X Lion or later. However, this can cause vertical gaps between glyph parts, because of hard-coded constants in RenderMathMLOperator.cpp. This was partially addressed in bug 84649, but not completely because RenderMathMLOperator::createStackableStyle still used a hard-coded font size of 14pt, while e.g. RenderMathMLOperator::glyphHeightForCharacter did not. This can be seen even with the current Symbol font, in the attached example.
Attachments
Gaps in stretched vertical bars (148 bytes, text/html)
2012-10-20 20:37 PDT, Dave Barton 		no flags
Details
Patch (591.71 KB, patch)
2012-10-20 21:36 PDT, Dave Barton 		no flags
DetailsFormatted DiffDiff
Patch (1.05 MB, patch)
2012-10-23 12:50 PDT, Dave Barton 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Barton
Comment 1 2012-10-20 21:36:28 PDT
Created attachment 169785 [details] Patch
spartha80
Comment 2 2012-10-23 08:13:09 PDT
Not all platforms currently implement platformBoundsForGlyph. The bound returned will be zero sized on some of them. Currently most of ports using Skia, FreeType for font rendering still work(I still haven't figured out how), maybe because of the values being hard coded in RenderMathMLOperator::glyphHeightForCharacter. That behavior may break with your patch. I will try integrating your patch over one of those ports and check.
Dave Barton
Comment 3 2012-10-23 09:49:55 PDT
Do the Skia/FreeType/etc. ports have ENABLE_MATHML on? Do they run pixel tests? The mac, efl, and gtk ports are the only ones with any LayoutTests/platform/*/mathml files. The apple/win port enables MathML, but doesn't run pixel tests. Until now, most web pages and libraries that use MathML browser-sniff and turn MathML off for WebKit, i.e. Safari. We've really had just a prototype implementation with many layout problems, and possible security issues. I've been fixing these, notably in r124512 (bug 43819) where I converted MathML to use { -webkit-line-box-contain: glyphs replaced; line-height: 0; }. This broke the efl and gtk ports because of no platformBoundsForGlyph as you (spartha80) say. Christophe Dumez was able to fix this on linux fairly quickly in bug 93073 - see its comments 8, 11 and 12, and its patch. It'd be great if a font expert could do this on other ports also, and then after this bug (99921) is fixed, I'd recommend MathML be enabled on all ports. For instance, we enabled MathML in Chrome in r130950 (bug 96960) two weeks ago, and I believe their automated fuzzers have not detected any security issues. I plan to send a message to webkit-dev summarizing all this, after this bug is resolved. (A somewhat revised patch is coming soon.) Thanks for your help and interest!
Dave Barton
Comment 4 2012-10-23 12:50:53 PDT
Created attachment 170208 [details] Patch
Eric Seidel (no email)
Comment 5 2012-10-23 12:57:35 PDT
Comment on attachment 170208 [details] Patch LGTM.
Dave Barton
Comment 6 2012-10-23 14:14:13 PDT
Committed r132264: <http://trac.webkit.org/changeset/132264>
Note You need to log in before you can comment on or make changes to this bug.