Bug 95679

Summary: [chromium] Wire up scrollable sublayers in ScrollingCoordinatorChromium
Product: WebKit Reporter: Sami Kyöstilä <skyostil>
Component: PlatformAssignee: Sami Kyöstilä <skyostil>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, cc-bugs, dglazkov, fishd, jamesr, tkent+wkapi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 78862    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch none

Sami Kyöstilä
Reported 2012-09-03 04:26:02 PDT
We should implement scrollable sublayers in ScrollingCoordinatorChromium.
Attachments
Patch (24.02 KB, patch)
2012-09-03 08:02 PDT, Sami Kyöstilä 		no flags
DetailsFormatted DiffDiff
Patch (25.64 KB, patch)
2012-09-05 04:29 PDT, Sami Kyöstilä 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sami Kyöstilä
Comment 1 2012-09-03 08:02:40 PDT
Created attachment 161929 [details] Patch Patch (requires 78862).
James Robinson
Comment 2 2012-09-04 12:26:06 PDT
Comment on attachment 161929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161929&action=review > Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp:132 > + MOCK_CONST_METHOD0(isActive, bool()); I don't think you really need a mock here at all - you just need a fake. I'd drop the gmock macros, etc, and just have empty implementations of the pure virtuals > Source/WebKit/chromium/tests/WebLayerTest.cpp:185 > + m_didScrollCalled = true; here, on the flip side, you've basically hand-rolled gmock's EXPECT_CALL :). I would use the gmock macros here since it's a small pure virtual interface
Sami Kyöstilä
Comment 3 2012-09-05 04:29:49 PDT
Created attachment 162216 [details] Patch - Added missing WebLayerScrollClient.h. - Not rolling my own test infrastructure :)
WebKit Review Bot
Comment 4 2012-09-05 04:35:13 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 5 2012-09-05 09:18:20 PDT
Comment on attachment 162216 [details] Patch Great!
WebKit Review Bot
Comment 6 2012-09-05 10:25:20 PDT
Comment on attachment 162216 [details] Patch Clearing flags on attachment: 162216 Committed r127605: <http://trac.webkit.org/changeset/127605>
WebKit Review Bot
Comment 7 2012-09-05 10:25:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.