Bug 93088

Summary: [Chromium] WebTouchCandidatesInfo should be part of the Client API
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 91648    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Peter Beverloo
Reported 2012-08-03 04:25:11 PDT
[Chromium] Add a forwarding header for WebTouchCandidatesInfo
Attachments
Patch (2.60 KB, patch)
2012-08-03 04:27 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch (8.07 KB, patch)
2012-08-05 10:03 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (8.50 KB, patch)
2012-08-06 15:02 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-08-03 04:27:42 PDT
Created attachment 156324 [details] Patch
Peter Beverloo
Comment 2 2012-08-03 04:28:47 PDT
Will files like this remain necessary, or will we be able to access the Source/Platform/chromium/public/* directory directly at some point? Files like this are kind of.. meh.
WebKit Review Bot
Comment 3 2012-08-03 04:31:20 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 4 2012-08-03 09:28:54 PDT
Comment on attachment 156324 [details] Patch Sorry, I missed that WebTouchCandidatesInfo was in Platform. We probably should move it to WebKit/chromium/public. Things related to events (e.g., mouse, touch) aren't concerns of the platform.
Adam Barth
Comment 5 2012-08-03 09:43:04 PDT
> Will files like this remain necessary, or will we be able to access the Source/Platform/chromium/public/* directory directly at some point? Files like this are kind of.. meh. We'll be able to include from Platform/chromium/public directly. That's pretty high on my list for after chromium-android is upstream.
Adam Barth
Comment 6 2012-08-05 10:03:13 PDT
Created attachment 156564 [details] Patch
Peter Beverloo
Comment 7 2012-08-05 10:04:29 PDT
(In reply to comment #4) > (From update of attachment 156324 [details]) > Sorry, I missed that WebTouchCandidatesInfo was in Platform. We probably should move it to WebKit/chromium/public. Things related to events (e.g., mouse, touch) aren't concerns of the platform. Got it. Abroad now, but I can take this tomorrow. How exactly is the difference defined? I.e. what goes in Source/Platform?
Peter Beverloo
Comment 8 2012-08-05 10:05:33 PDT
(In reply to comment #6) > Created an attachment (id=156564) [details] > Patch ..or not :-). Thanks.
WebKit Review Bot
Comment 9 2012-08-05 10:19:54 PDT
Comment on attachment 156564 [details] Patch Attachment 156564 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13435550
Adam Barth
Comment 10 2012-08-06 14:46:37 PDT
> Got it. Abroad now, but I can take this tomorrow. How exactly is the difference defined? I.e. what goes in Source/Platform? Here's a diagram that tries to explain it: https://docs.google.com/drawings/d/1GJXd6XSLEehvuqA7Xbvbz0OH6Znnr2iTijihjrEY0ts/edit I should expand http://trac.webkit.org/wiki/ChromiumWebKitAPI to explain more. The idea is that Platform is the API to the lower layers of the system (e.g., OS facilities) whereas the Client API (the one in WebKit/chromium/public) is the one that the higher levels of the system use to communicate with WebKit.
Adam Barth
Comment 11 2012-08-06 15:02:21 PDT
Created attachment 156768 [details] Patch
WebKit Review Bot
Comment 12 2012-08-06 16:33:26 PDT
Comment on attachment 156768 [details] Patch Clearing flags on attachment: 156768 Committed r124813: <http://trac.webkit.org/changeset/124813>
WebKit Review Bot
Comment 13 2012-08-06 16:33:31 PDT
All reviewed patches have been landed. Closing bug.
Peter Beverloo
Comment 14 2012-08-13 02:41:07 PDT
A bit late, but thank you for doing this, Adam!
Note You need to log in before you can comment on or make changes to this bug.