Bug 92698

Summary: [chromium]Upstream WebViewImpl:StartPageScaleAnimation changes for Chrome for Android
Product: WebKit Reporter: yusufo
Component: New BugsAssignee: yusufo
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

yusufo
Reported 2012-07-30 18:11:23 PDT
[chromium]Upstream WebViewImpl:StartPageScaleAnimation changes for Chrome for Android
Attachments
Patch (2.88 KB, patch)
2012-07-30 18:12 PDT, yusufo 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2012-07-31 16:13 PDT, yusufo 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2012-07-31 16:26 PDT, yusufo 		no flags
DetailsFormatted DiffDiff
Patch (2.09 KB, patch)
2012-07-31 17:01 PDT, yusufo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
yusufo
Comment 1 2012-07-30 18:12:53 PDT
Created attachment 155411 [details] Patch
Adam Barth
Comment 2 2012-07-30 20:29:41 PDT
Comment on attachment 155411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155411&action=review Thanks for the patch. A number of minor comments below. > Source/WebKit/chromium/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Please replace this line of the ChangeLog with a description of why you;re making this change. > Source/WebKit/chromium/src/WebViewImpl.cpp:771 > -void WebViewImpl::startPageScaleAnimation(const IntPoint& scroll, bool useAnchor, float newScale, double durationInSeconds) > +void WebViewImpl::startPageScaleAnimation(const WebPoint& targetPosition, bool useAnchor, float newScale, double durationSec) Typically we use WebCore types (e.g., IntPoint) in the implementation and reserve API types (e.g., WebPoint) for the API. We shouldn't rename durationInSeconds to durationSec. WebKit prefers variable names that use complete works and (ideally) English grammar. > Source/WebKit/chromium/src/WebViewImpl.cpp:781 > + setPageScaleFactor(newScale, clampedPoint); Please use four-space indent.
yusufo
Comment 3 2012-07-31 16:13:27 PDT
Created attachment 155663 [details] Patch
yusufo
Comment 4 2012-07-31 16:26:47 PDT
Created attachment 155670 [details] Patch
Adam Barth
Comment 5 2012-07-31 16:56:59 PDT
Comment on attachment 155670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155670&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:778 > + clampedPoint = clampOffsetAtScale(targetPosition, newScale); Four-space indent.
yusufo
Comment 6 2012-07-31 17:01:55 PDT
Created attachment 155678 [details] Patch
yusufo
Comment 7 2012-07-31 17:02:13 PDT
Thanks a lot!
WebKit Review Bot
Comment 8 2012-07-31 19:56:11 PDT
Comment on attachment 155678 [details] Patch Clearing flags on attachment: 155678 Committed r124288: <http://trac.webkit.org/changeset/124288>
WebKit Review Bot
Comment 9 2012-07-31 19:56:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.