Bug 92295

Summary: [WebGL] ANGLEWebKitBridge should support ESSL platforms
Product: WebKit Reporter: Joshua Netterfield <jnetterfield>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Netterfield
Reported 2012-07-25 14:04:11 PDT
There should be a way for ESSL platforms to request ESSL output from ANGLE.
Attachments
Patch (2.94 KB, patch)
2012-07-25 16:44 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Patch (3.10 KB, patch)
2012-07-26 06:53 PDT, Joshua Netterfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Netterfield
Comment 1 2012-07-25 16:04:07 PDT
Didn't see https://bugs.webkit.org/show_bug.cgi?id=87718 (it hasn't landed in our downstream repo yet). This bug is now for having Blackberry take advantage of that.
Joshua Netterfield
Comment 2 2012-07-25 16:44:54 PDT
Created attachment 154480 [details] Patch
Rob Buis
Comment 3 2012-07-25 19:38:16 PDT
Comment on attachment 154480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154480&action=review > Source/WebCore/ChangeLog:9 > + glsl-mat4-to-mat3.html) To me as an GLES and shader n00b, it is not clear how the two code sections relate? What does SH_ESSL_OUTPUT do, and why does it mean the hack can be removed? You may have to improve the commit message so more people understand how this change fixes the problem.
Joshua Netterfield
Comment 4 2012-07-26 06:53:14 PDT
Created attachment 154645 [details] Patch
Rob Buis
Comment 5 2012-07-26 06:54:57 PDT
Comment on attachment 154645 [details] Patch Okay.
WebKit Review Bot
Comment 6 2012-07-26 08:26:09 PDT
Comment on attachment 154645 [details] Patch Clearing flags on attachment: 154645 Committed r123749: <http://trac.webkit.org/changeset/123749>
WebKit Review Bot
Comment 7 2012-07-26 08:26:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.