Bug 92126

Summary: Android-chromium layout tests failing with GPU related crash
Product: WebKit Reporter: Ben Murdoch <benm>
Component: Tools / TestsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, peter, wangxianzhu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Ben Murdoch
Reported 2012-07-24 09:05:27 PDT
It appears that the --enable-hardware-gpu flag is not being propogated into Android's DRT correctly, which means that we end up falling back to the software renderer, which leads to CHECK failures in chromium code. If I hardcode the --enable-hardware-gpu flag on in DRT with the following patch: --- a/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp +++ b/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp @@ -201,6 +203,7 @@ int main(int argc, char* argv[]) return EXIT_FAILURE; } + hardwareAcceleratedGL = true; webkit_support::SetUpGLBindings(hardwareAcceleratedGL ? webkit_support::GL_BINDING_DEFAULT : webkit_support::GL_BINDING_SOFTWARE_RENDERER); if (startupDialog) I don't see the crashes.
Attachments
Patch (3.95 KB, patch)
2012-07-24 09:33 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-07-24 09:21:37 PDT
I found the issue and will upload a patch soon. Just trying to figure out how to run the unit tests now..
Peter Beverloo
Comment 2 2012-07-24 09:33:48 PDT
Created attachment 154085 [details] Patch
Peter Beverloo
Comment 3 2012-07-24 10:05:09 PDT
Ben verified that this fixes the issue :).
WebKit Review Bot
Comment 4 2012-07-24 12:40:47 PDT
Comment on attachment 154085 [details] Patch Clearing flags on attachment: 154085 Committed r123507: <http://trac.webkit.org/changeset/123507>
WebKit Review Bot
Comment 5 2012-07-24 12:40:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.