Bug 91674

Summary: [chromium] Implement scrollbar theme for Android
Product: WebKit Reporter: Tien-Ren Chen <trchen>
Component: New BugsAssignee: Tien-Ren Chen <trchen>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, klobag, peter, trchen, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch for landing none

Tien-Ren Chen
Reported 2012-07-18 14:48:09 PDT
[chromium] Implement scrollbar theme for Android
Attachments
Patch (8.79 KB, patch)
2012-07-18 15:28 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.71 KB, patch)
2012-07-23 15:50 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tien-Ren Chen
Comment 1 2012-07-18 15:28:22 PDT
Created attachment 153103 [details] Patch
Peter Beverloo
Comment 2 2012-07-19 02:02:15 PDT
Please be sure that your patches block bug 66687, that helps us to keep track. Thanks!
Adam Barth
Comment 3 2012-07-19 09:08:44 PDT
Comment on attachment 153103 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153103&action=review Some minor style nits below. > Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:66 > + float proportion = (float)scrollbar->currentPos() / scrollbar->totalSize(); WebKit preferes C++ style casts, so static_cast<float>(...) > Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:103 > +namespace { WebKit tends to use static functions rather than anonymous namespaces. > Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.h:53 > + static const int s_scrollbarWidth = 8; > + static const int s_scrollbarMargin = 5; WebKit doesn't use the s_ prefix for static variables. We just use bare names like scrollbarWidth (and we tend to put them in the implementation file rather than the header if they're not used outside the implementation).
Adam Barth
Comment 4 2012-07-23 15:50:27 PDT
Created attachment 153885 [details] Patch for landing
Adam Barth
Comment 5 2012-07-23 15:50:57 PDT
@trchen: I fixed the nits for you. Please let me know if I've goofed them up. Thanks for the patch.
WebKit Review Bot
Comment 6 2012-07-23 16:39:13 PDT
Comment on attachment 153885 [details] Patch for landing Clearing flags on attachment: 153885 Committed r123402: <http://trac.webkit.org/changeset/123402>
WebKit Review Bot
Comment 7 2012-07-23 16:39:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.