Bug 91539

Summary: Remove NRWT --shard-ref-tests once --pixel-tests argument can be passed as a per-test-arg
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 91538    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Xianzhu Wang
Reported 2012-07-17 13:45:45 PDT
Bug 91533 adds --shard-ref-tests to reduce the cost of restarting the driver/DRT when switching between pixel mode and non-pixel mode. After we have --pixel-tests passed as a per-test arg to DRT, we can have one driver/DRT instance supporting both pixel and non-pixel tests, so the --shard-ref-tests will be unnecessary.
Attachments
Patch (15.43 KB, patch)
2012-08-06 13:39 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-08-06 13:39:06 PDT
Created attachment 156755 [details] Patch
Xianzhu Wang
Comment 2 2012-08-06 13:41:26 PDT
I wish I'd not have made the change for bug 91533 :)
Dirk Pranke
Comment 3 2012-08-06 13:41:50 PDT
Comment on attachment 156755 [details] Patch yay for deleting code :).
WebKit Review Bot
Comment 4 2012-08-06 16:20:13 PDT
Comment on attachment 156755 [details] Patch Clearing flags on attachment: 156755 Committed r124809: <http://trac.webkit.org/changeset/124809>
WebKit Review Bot
Comment 5 2012-08-06 16:20:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.