Bug 91501

Summary:

[Qt] svg/transforms tests needs update after rebaseline and new testfonts

Product:

WebKit

Reporter:

Bruno Abinader (history only) <bruno.abinader>

Component:

WebKit Qt

Assignee:

Bruno Abinader (history only) <bruno.abinader>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

85203

Attachments:

Description	Flags
Proposed patch	menard: review+, webkit.review.bot: commit-queue-
Proposed patch (v2) + missing ChangeLog	none

Bruno Abinader (history only)

Reported 2012-07-17 06:48:38 PDT

After the rebaseline proposed by Bug 85203 - [Qt] DumpRenderTree does not use 'monospace' font when directed, svg/transforms tests directory needs to be updated.

Attachments
Proposed patch (685.58 KB, patch) 2012-07-17 07:48 PDT, Bruno Abinader (history only)	menard: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Proposed patch (v2) + missing ChangeLog (687.40 KB, patch) 2012-07-17 14:02 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Bruno Abinader (history only)

Comment 1 2012-07-17 07:48:12 PDT

Created attachment 152761 [details] Proposed patch Proposed patch

Alexis Menard (darktears)

Comment 2 2012-07-17 07:55:19 PDT

Comment on attachment 152761 [details] Proposed patch rs=me.

WebKit Review Bot

Comment 3 2012-07-17 08:54:40 PDT

Comment on attachment 152761 [details] Proposed patch Rejecting attachment 152761 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: mit-queue/Source/WebKit/chromium/third_party/skia/src --revision 4552 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 45>At revision 4552. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13276161

Bruno Abinader (history only)

Comment 4 2012-07-17 09:21:13 PDT

Did this patch actually caused this or just a chromium bot failure? (In reply to comment #3) > (From update of attachment 152761 [details]) > Rejecting attachment 152761 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > mit-queue/Source/WebKit/chromium/third_party/skia/src --revision 4552 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > 45>At revision 4552. > > ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > > ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' > Updating webkit projects from gyp files... > > Full output: http://queues.webkit.org/results/13276161

Bruno Abinader (history only)

Comment 5 2012-07-17 09:33:54 PDT

Comment on attachment 152761 [details] Proposed patch Asking for commit queue again (previous denial sounds like a chromium bot-only issue).

WebKit Review Bot

Comment 6 2012-07-17 13:50:59 PDT

Comment on attachment 152761 [details] Proposed patch Rejecting attachment 152761 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: queue/Source/WebKit/chromium/third_party/sfntly/cpp/src --revision 134 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 43>At revision 134. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13270251

Bruno Abinader (history only)

Comment 7 2012-07-17 14:02:10 PDT

Created attachment 152824 [details] Proposed patch (v2) + missing ChangeLog Sorry guys, somehow the ChangeLog got missing on this patch, fixed now.

Alexis Menard (darktears)

Comment 8 2012-07-17 14:21:02 PDT

Comment on attachment 152824 [details] Proposed patch (v2) + missing ChangeLog rs=me

WebKit Review Bot

Comment 9 2012-07-17 15:09:16 PDT

Comment on attachment 152824 [details] Proposed patch (v2) + missing ChangeLog Clearing flags on attachment: 152824 Committed r122878: <http://trac.webkit.org/changeset/122878>

WebKit Review Bot

Comment 10 2012-07-17 15:09:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.