Bug 91399

Summary: [Qt] platform/qt/editing/pasteboard tests needs update after rebaseline and new testfonts (75)
Product: WebKit Reporter: Ádám Kallai <kadam>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, hausmann, kkristof, ossy, szledan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85203    
Attachments:
Description Flags
proposed patch
none
proposed patch
none
proposed patch
none
proposed patch
ossy: review+, webkit.review.bot: commit-queue-
proposed patch
webkit.review.bot: commit-queue-
proposed patch none

Ádám Kallai
Reported 2012-07-16 09:06:35 PDT
I'm updating test expectations after font change.
Attachments
proposed patch (deleted)
2012-07-16 09:17 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
proposed patch (deleted)
2012-07-23 05:17 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
proposed patch (deleted)
2012-07-24 05:01 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
proposed patch (deleted)
2012-07-25 07:05 PDT, Ádám Kallai 		ossy: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
proposed patch (deleted)
2012-07-26 09:05 PDT, Ádám Kallai 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
proposed patch (deleted)
2012-07-26 23:50 PDT, Ádám Kallai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Ádám Kallai
Comment 1 2012-07-16 09:17:21 PDT
Created attachment 152549 [details] proposed patch I updated test expectations and png. I skipped a failing test.
Simon Hausmann
Comment 2 2012-07-19 07:21:55 PDT
Did you forget to set r?
Caio Marcelo de Oliveira Filho
Comment 3 2012-07-19 09:27:22 PDT
Fixing typo in the bug title.
Ádám Kallai
Comment 4 2012-07-23 01:56:02 PDT
Sorry, I forgot to set r?. I'll fix it.
Ádám Kallai
Comment 5 2012-07-23 05:17:24 PDT
Created attachment 153778 [details] proposed patch Update last patch.
Caio Marcelo de Oliveira Filho
Comment 6 2012-07-23 11:13:07 PDT
Comment on attachment 153778 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=153778&action=review > LayoutTests/platform/qt-5.0/Skipped:1552 > +editing/pasteboard/4944770-1.html > +editing/pasteboard/4944770-2.html Are these two still failing? They seem to work here.
Ádám Kallai
Comment 7 2012-07-24 01:31:27 PDT
It's very interesting. These tests wasn't working, when I tested them therefore I left them on skippedlist. I'm going to testing again. Maybe I was inattentive.
Ádám Kallai
Comment 8 2012-07-24 03:58:47 PDT
You were right. :) Thanks for the review. I was inattentive. :( I added new expectations to platform/qt but these tests had some older expectations in qt-5.0-wk2 and qt-5.0 too. When I was testing it the script didn't consider platform/qt baseline directory. Those expectations will be deleted and it will work fine.
Ádám Kallai
Comment 9 2012-07-24 05:01:11 PDT
Created attachment 154023 [details] proposed patch I updated my patch. Now these tests are working well.
Ádám Kallai
Comment 10 2012-07-25 07:05:48 PDT
Created attachment 154343 [details] proposed patch I think patch is ready. I hope it's working now. Could you have look at it please?
Csaba Osztrogonác
Comment 11 2012-07-25 07:15:47 PDT
Comment on attachment 154343 [details] proposed patch rs=me
WebKit Review Bot
Comment 12 2012-07-25 07:21:41 PDT
Comment on attachment 154343 [details] proposed patch Rejecting attachment 154343 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s/platform/qt/editing/pasteboard/smart-paste-007-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/styled-element-markup-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/unrendered-br-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13341254
Caio Marcelo de Oliveira Filho
Comment 13 2012-07-25 11:37:10 PDT
Maybe the patch needs to be rebased?
Ádám Kallai
Comment 14 2012-07-26 09:05:44 PDT
Created attachment 154663 [details] proposed patch I'm ready to update.
WebKit Review Bot
Comment 15 2012-07-26 11:22:34 PDT
Comment on attachment 154663 [details] proposed patch Rejecting attachment 154663 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ed.txt patching file LayoutTests/platform/qt/editing/pasteboard/smart-paste-007-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/styled-element-markup-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/unrendered-br-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13349870
Ádám Kallai
Comment 16 2012-07-26 23:50:11 PDT
Created attachment 154856 [details] proposed patch Update.
WebKit Review Bot
Comment 17 2012-07-27 01:04:27 PDT
Comment on attachment 154856 [details] proposed patch Rejecting attachment 154856 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13361989
WebKit Review Bot
Comment 18 2012-07-27 04:12:01 PDT
Comment on attachment 154856 [details] proposed patch Clearing flags on attachment: 154856 Committed r123862: <http://trac.webkit.org/changeset/123862>
WebKit Review Bot
Comment 19 2012-07-27 04:12:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.