Bug 91011

Summary: Simplify css3/flexbox/repaint-rtl-column.html
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch tony: review+

Ojan Vafai
Reported 2012-07-11 13:45:35 PDT
Simplify css3/flexbox/repaint-rtl-column.html
Attachments
Patch (35.71 KB, patch)
2012-07-11 13:46 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (35.86 KB, patch)
2012-07-11 14:27 PDT, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-07-11 13:46:37 PDT
Created attachment 151762 [details] Patch
Tony Chang
Comment 2 2012-07-11 13:59:33 PDT
Comment on attachment 151762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151762&action=review > LayoutTests/css3/flexbox/repaint-rtl-column.html:18 > + height: 350px; I'm not sure we should hard code a height here. The original bug was that we would leave some text in the middle of the page that didn't get cleared by the repaint. You might want to try reverting the code change associated with this test to verify that this new test triggers the failure. > LayoutTests/css3/flexbox/repaint-rtl-column.html:36 > + document.getElementById("content").style.webkitFlex = "5"; > + if (window.testRunner) > + testRunner.notifyDone(); The test used to set the flex to 2 different values, but now only sets it once. Is that the same?
Ojan Vafai
Comment 3 2012-07-11 14:27:24 PDT
Created attachment 151776 [details] Patch
Ojan Vafai
Comment 4 2012-07-11 14:28:13 PDT
Comment on attachment 151762 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151762&action=review >> LayoutTests/css3/flexbox/repaint-rtl-column.html:18 >> + height: 350px; > > I'm not sure we should hard code a height here. The original bug was that we would leave some text in the middle of the page that didn't get cleared by the repaint. You might want to try reverting the code change associated with this test to verify that this new test triggers the failure. As discussed in person, this is changing the content of the flex item. It's the flex item's height that changes. >> LayoutTests/css3/flexbox/repaint-rtl-column.html:36 >> + testRunner.notifyDone(); > > The test used to set the flex to 2 different values, but now only sets it once. Is that the same? I added back in the two values and the setTimeouts.
Tony Chang
Comment 5 2012-07-11 14:33:17 PDT
Comment on attachment 151776 [details] Patch Please mention in the ChangeLog that this also reveals a bug in repainting outline.
Ojan Vafai
Comment 6 2012-07-11 14:52:31 PDT
Committed r122374: <http://trac.webkit.org/changeset/122374>
Note You need to log in before you can comment on or make changes to this bug.