Bug 89464

Summary: Web Inspector: Clicking "Clear all profiles" while ongoing recording should reset the ProfileLauncherView
Product: WebKit Reporter: Vivek Galatage <vivekgalatage>
Component: Web Inspector (Deprecated)Assignee: Vivek Galatage <vivekgalatage>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Vivek Galatage
Reported 2012-06-19 05:51:04 PDT
Steps: 1. Launch inspector and navigate to Profiles panel 2. Click on start button to start a profiling session 3. Now click on "Clear all profiles" button at the bottom while the recording is ongoing. Expected Outcome: The profiles view should be reset Actual outcome: The buttons on the panel still shows Stop and the status bar record button still shows red.
Attachments
Patch (1.50 KB, patch)
2012-06-19 05:53 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.58 KB, patch)
2012-06-19 06:19 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-06-19 05:53:49 PDT
Created attachment 148318 [details] Patch
Yury Semikhatsky
Comment 2 2012-06-19 06:04:43 PDT
Comment on attachment 148318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148318&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:381 > + this.recordButton.title = ""; Could you call toggleRecordButton instead if we are currently profiling the page to leave correct button title?
Vivek Galatage
Comment 3 2012-06-19 06:17:14 PDT
(In reply to comment #2) > (From update of attachment 148318 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148318&action=review > > > Source/WebCore/inspector/front-end/ProfilesPanel.js:381 > > + this.recordButton.title = ""; > > Could you call toggleRecordButton instead if we are currently profiling the page to leave correct button title? Thank you Yury for the review. I tried calling toggleRecordButton before this fix but this will result in calling the takeHeapSnapshot for HeapSnapshotView.js as toggleRecordButton invokes buttonClicked method. Hence have done some corrections to setting the correct tooltip after reset. Uploading it again for your review.
Vivek Galatage
Comment 4 2012-06-19 06:19:53 PDT
Created attachment 148322 [details] Patch
WebKit Review Bot
Comment 5 2012-06-19 23:51:51 PDT
Comment on attachment 148322 [details] Patch Clearing flags on attachment: 148322 Committed r120809: <http://trac.webkit.org/changeset/120809>
WebKit Review Bot
Comment 6 2012-06-19 23:51:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.