Bug 89236

Summary: [BlackBerry] Put platform-specific GC policy in GCActivityCallback
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
none
fix the style error none

Yong Li
Reported 2012-06-15 11:49:13 PDT
to add a GCActivityCallbackBlackBerry.cpp, and put our low memory GC policy into didAllocate().
Attachments
the patch (4.46 KB, patch)
2012-06-15 12:23 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
fix the style error (4.46 KB, patch)
2012-06-15 12:41 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-06-15 12:23:59 PDT
Created attachment 147874 [details] the patch Geoffrey, the patch adds one line to Heap.h: bool isSafeToCollect() const { return m_isSafeToCollect; } Do you think it is OK?
WebKit Review Bot
Comment 2 2012-06-15 12:28:46 PDT
Attachment 147874 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp:22: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp:28: Missing space inside { }. [whitespace/braces] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yong Li
Comment 3 2012-06-15 12:41:47 PDT
Created attachment 147878 [details] fix the style error
Rob Buis
Comment 4 2012-06-15 14:35:09 PDT
Comment on attachment 147878 [details] fix the style error Looks good.
Geoffrey Garen
Comment 5 2012-06-15 14:44:00 PDT
> bool isSafeToCollect() const { return m_isSafeToCollect; } This is fine. Seriously, though, you're making GC on Blackberry O(n^2).
Yong Li
Comment 6 2012-06-15 14:47:34 PDT
(In reply to comment #5) > > bool isSafeToCollect() const { return m_isSafeToCollect; } > > This is fine. > > Seriously, though, you're making GC on Blackberry O(n^2). It is still using a limit which is just the small one (1MB). I commented the isMemoryLow check and tested it on some heavy sites. It is a bit slower, but seems still OK.
WebKit Review Bot
Comment 7 2012-06-15 15:32:09 PDT
Comment on attachment 147878 [details] fix the style error Clearing flags on attachment: 147878 Committed r120502: <http://trac.webkit.org/changeset/120502>
WebKit Review Bot
Comment 8 2012-06-15 15:32:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.