Bug 89044

Summary: Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
Product: WebKit Reporter: Min Qin <qinmin>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Min Qin
Reported 2012-06-13 15:40:19 PDT
Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
Attachments
Patch (1.48 KB, patch)
2012-06-13 15:44 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2012-06-13 15:55 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Patch (3.72 KB, patch)
2012-06-13 16:12 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Patch (3.71 KB, patch)
2012-06-13 16:15 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Min Qin
Comment 1 2012-06-13 15:44:11 PDT
Created attachment 147432 [details] Patch
Peter Beverloo
Comment 2 2012-06-13 15:49:23 PDT
You'll want to revert the changes made in r120213 as well, as well as any downstream change.
Min Qin
Comment 3 2012-06-13 15:55:13 PDT
Created attachment 147434 [details] Patch
Min Qin
Comment 4 2012-06-13 15:57:18 PDT
Did not notice that we have changed WebMediaPlayerClientImpl. Reverted that change as a result of this change. (In reply to comment #2) > You'll want to revert the changes made in r120213 as well, as well as any downstream change.
Peter Beverloo
Comment 5 2012-06-13 15:57:29 PDT
Comment on attachment 147434 [details] Patch Please also amend Source/WebKit/chromium/ChangeLog with the change. LGTM after that, thank you! You could carry-over Adam's r+ by changing the "Reviewed by" line in the changelog, I (of anyone else) can put the patch on the commit queue after that.
Min Qin
Comment 6 2012-06-13 16:12:21 PDT
Created attachment 147441 [details] Patch
Peter Beverloo
Comment 7 2012-06-13 16:13:48 PDT
LGTM. Adam, could you take a look and r+/cq+ please?
Min Qin
Comment 8 2012-06-13 16:15:28 PDT
Created attachment 147442 [details] Patch
Min Qin
Comment 9 2012-06-13 16:16:43 PDT
Done, added the chromium ChangeLog and changed the reviewer to Adam (In reply to comment #5) > (From update of attachment 147434 [details]) > Please also amend Source/WebKit/chromium/ChangeLog with the change. LGTM after that, thank you! You could carry-over Adam's r+ by changing the "Reviewed by" line in the changelog, I (of anyone else) can put the patch on the commit queue after that.
WebKit Review Bot
Comment 10 2012-06-14 02:26:09 PDT
Comment on attachment 147442 [details] Patch Clearing flags on attachment: 147442 Committed r120298: <http://trac.webkit.org/changeset/120298>
WebKit Review Bot
Comment 11 2012-06-14 02:26:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.