Bug 88152

Summary:

Rename the flexbox CSS propery values from start to flex-start and end to flex-end

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, dglazkov, eric, macpherson, menard, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

62048

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cq-02	none
Archive of layout-test-results from ec2-cr-linux-01	none
Patch for landing	none
Patch for landing	none

Tony Chang

Reported 2012-06-01 16:36:15 PDT

Rename the flexbox CSS propery values from start to flex-start and end to flex-end

Attachments
Patch (186.07 KB, patch) 2012-06-01 16:39 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cq-02 (547.35 KB, application/zip) 2012-06-01 22:56 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from ec2-cr-linux-01 (500.94 KB, application/zip) 2012-06-01 23:06 PDT, WebKit Review Bot	no flags	Details
Patch for landing (196.17 KB, patch) 2012-06-01 23:18 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Patch for landing (197.18 KB, patch) 2012-06-01 23:25 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2012-06-01 16:39:47 PDT

Created attachment 145406 [details] Patch

WebKit Review Bot

Comment 2 2012-06-01 22:56:43 PDT

Comment on attachment 145406 [details] Patch Rejecting attachment 145406 [details] from commit-queue. New failing tests: fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style.html Full output: http://queues.webkit.org/results/12888168

WebKit Review Bot

Comment 3 2012-06-01 22:56:47 PDT

Created attachment 145428 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

WebKit Review Bot

Comment 4 2012-06-01 23:06:54 PDT

Comment on attachment 145406 [details] Patch Attachment 145406 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12870697 New failing tests: fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style.html

WebKit Review Bot

Comment 5 2012-06-01 23:06:59 PDT

Created attachment 145430 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Tony Chang

Comment 6 2012-06-01 23:18:47 PDT

Created attachment 145431 [details] Patch for landing

Tony Chang

Comment 7 2012-06-01 23:25:45 PDT

Created attachment 145432 [details] Patch for landing

WebKit Review Bot

Comment 8 2012-06-02 01:15:25 PDT

Comment on attachment 145432 [details] Patch for landing Clearing flags on attachment: 145432 Committed r119316: <http://trac.webkit.org/changeset/119316>

WebKit Review Bot

Comment 9 2012-06-02 01:15:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.