Bug 88029

Summary: content-element-api.html and shadow-element.html depend on V8
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Tools / TestsAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87732    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cq-02
none
Patch for landing none

Hajime Morrita
Reported 2012-05-31 17:28:49 PDT
It could be portable between V8 and JSC. (Based on the feedback at Bug 86859)
Attachments
Patch (2.16 KB, patch)
2012-05-31 17:47 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cq-02 (530.98 KB, application/zip)
2012-05-31 18:40 PDT, WebKit Review Bot 		no flags
Details
Patch for landing (3.62 KB, patch)
2012-06-05 03:15 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-05-31 17:47:33 PDT
Created attachment 145181 [details] Patch
Kentaro Hara
Comment 2 2012-05-31 17:48:06 PDT
Comment on attachment 145181 [details] Patch Looks OK
WebKit Review Bot
Comment 3 2012-05-31 18:40:46 PDT
Comment on attachment 145181 [details] Patch Rejecting attachment 145181 [details] from commit-queue. New failing tests: fast/dom/shadow/content-element-api.html fast/dom/shadow/shadow-element.html Full output: http://queues.webkit.org/results/12862445
WebKit Review Bot
Comment 4 2012-05-31 18:40:49 PDT
Created attachment 145190 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Chris Dumez
Comment 5 2012-06-03 22:43:14 PDT
Could we get this one fixed/committed please?
Chris Dumez
Comment 6 2012-06-03 22:52:30 PDT
Comment on attachment 145181 [details] Patch I believe you forgot to update the expected results.
Kentaro Hara
Comment 7 2012-06-03 22:57:14 PDT
(In reply to comment #6) > (From update of attachment 145181 [details]) > I believe you forgot to update the expected results. Yeah. morrita: would you update the results and land the patch?
Hajime Morrita
Comment 8 2012-06-04 19:04:56 PDT
> Yeah. morrita: would you update the results and land the patch? oops. thanks for the reminder. will do.
Hajime Morrita
Comment 9 2012-06-05 03:15:20 PDT
Created attachment 145743 [details] Patch for landing
WebKit Review Bot
Comment 10 2012-06-05 04:28:41 PDT
Comment on attachment 145743 [details] Patch for landing Clearing flags on attachment: 145743 Committed r119481: <http://trac.webkit.org/changeset/119481>
WebKit Review Bot
Comment 11 2012-06-05 04:28:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.