Bug 87710

Summary: Allow ports to make plugins focusable
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, epenner, eric, peter
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-05-29 01:46:33 PDT
Allow ports to make plugins focusable
Attachments
Patch (4.82 KB, patch)
2012-05-29 01:51 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-05-29 01:51:43 PDT
Created attachment 144478 [details] Patch
Adam Barth
Comment 2 2012-05-29 01:54:33 PDT
Comment on attachment 144478 [details] Patch Clearing the review flag for a moment. I need to study the interaction between this patch and one other thing.
Peter Beverloo
Comment 3 2012-05-29 01:54:49 PDT
+epenner This seems to be quite old code, Eric (Penner), could you comment on whether we want this upstreamed right now?
Alexey Proskuryakov
Comment 4 2012-05-29 12:29:19 PDT
This is surprising, because I can certainly focus Flash plug-ins to type in them in Safari on Mac and Windows. Keyboard also works in YouTube for controlling movies.
Adam Barth
Comment 5 2012-05-29 16:39:29 PDT
Yes, I believe this patch isn't correct. I'll post a patch to the chromium-android branch to remove it.
Eric Penner
Comment 6 2012-05-29 16:59:44 PDT
This was needed to support the case where events should only arrive when the plugin has focus, rather than all the time. In that case this is needed to insure the plugin gets focus when desired which is slightly different from when it would normally get focus. The code is indeed old, but I believe it's a valid use-case for plugins, when you don't always want them to receive events on a mobile device (but rather only when you tap on it first).
Adam Barth
Comment 7 2012-05-29 17:10:38 PDT
As far as I know, we're abandoning support for plugins on the chromium-android branch. That means instead of moving this patch upstream, we should remove it from downstream. If there's another reason to make this change, we can make the change again in the future when we have that need.
Note You need to log in before you can comment on or make changes to this bug.