Bug 87679

Summary:

Vertical writing mode can overflow fixed size grandparent container

Product:

WebKit

Reporter:

Victor Carbune <vcarbune>

Component:

CSS

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, gustavo, hyatt, jchaffraix, mitz, ojan, tony, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

88116

Bug Blocks:

62048

Attachments:

Description	Flags
html page	none
screenshot of how it renders	none
reduced test case	none
Patch	none
Archive of layout-test-results from ec2-cr-linux-01	none
Patch	none
Patch	none
reduction	none

Victor Carbune

Reported 2012-05-28 15:12:15 PDT

Created attachment 144401 [details] html page The height of the parent containing block is not respected and the text overflows. (-webkit-flex: 1) There are multiple nested layouts in the example (using display:-webkit-flex)

Attachments
html page (2.22 KB, text/html) 2012-05-28 15:12 PDT, Victor Carbune	no flags	Details
screenshot of how it renders (28.46 KB, image/png) 2012-05-28 15:15 PDT, Victor Carbune	no flags	Details
reduced test case (757 bytes, text/html) 2012-05-31 11:04 PDT, Ojan Vafai	no flags	Details
Patch (4.22 KB, patch) 2012-05-31 12:30 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (1.03 MB, application/zip) 2012-05-31 18:43 PDT, WebKit Review Bot	no flags	Details
Patch (4.29 KB, patch) 2012-06-01 16:07 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
Patch (4.29 KB, patch) 2012-06-05 11:43 PDT, Ojan Vafai	no flags	Details Formatted Diff Diff
reduction (642 bytes, text/html) 2012-06-08 11:24 PDT, Tony Chang	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Victor Carbune

Comment 1 2012-05-28 15:15:49 PDT

Created attachment 144402 [details] screenshot of how it renders

Ojan Vafai

Comment 2 2012-05-31 10:45:17 PDT

This test case is very complicated. Just to be clear, the only bug here is that verticalGrowingLeftContainer grows outside of verticalCueContainer, right? Or are there multiple bugs?

Ojan Vafai

Comment 3 2012-05-31 11:04:21 PDT

Created attachment 145115 [details] reduced test case

Ojan Vafai

Comment 4 2012-05-31 12:30:18 PDT

Created attachment 145134 [details] Patch

Ojan Vafai

Comment 5 2012-05-31 12:31:13 PDT

Hyatt, this should be a simple 2-line review. Mind taking a quick look? I don't think there's anyone but you and I familiar with vertical writing mode. :)

Victor Carbune

Comment 6 2012-05-31 14:14:53 PDT

(In reply to comment #2) > This test case is very complicated. Just to be clear, the only bug here is that verticalGrowingLeftContainer grows outside of verticalCueContainer, right? Or are there multiple bugs? Right, that should be it. Sorry about the fairly complicated csae, but that's what I was working on.

Ojan Vafai

Comment 7 2012-05-31 14:18:06 PDT

(In reply to comment #6) > (In reply to comment #2) > > This test case is very complicated. Just to be clear, the only bug here is that verticalGrowingLeftContainer grows outside of verticalCueContainer, right? Or are there multiple bugs? > > Right, that should be it. Sorry about the fairly complicated csae, but that's what I was working on. No worries. Just wanted to make sure I wasn't missing something.

WebKit Review Bot

Comment 8 2012-05-31 18:43:41 PDT

Comment on attachment 145134 [details] Patch Attachment 145134 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12862446 New failing tests: perf/object-keys.html fast/html/details-writing-mode.html

WebKit Review Bot

Comment 9 2012-05-31 18:43:46 PDT

Created attachment 145191 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Julien Chaffraix

Comment 10 2012-06-01 09:11:46 PDT

Comment on attachment 145134 [details] Patch The fix looks OK, but it seems to make us regress a table test. It's a shot in the dark but RenderTableSection::calcRowLogicalHeight has some special case for overrideHeight that may be impacted.

Ojan Vafai

Comment 11 2012-06-01 09:37:41 PDT

Comment on attachment 145134 [details] Patch Yeah, I saw that. I should have removed the r?. I was working on it last night. It turns out to be tricky to fix. Different uses of overrideHeight seem to include or not incude border+padding. Making the same causes more tests to fail for reasons I don't understand. :(

Ojan Vafai

Comment 12 2012-06-01 16:07:25 PDT

Created attachment 145398 [details] Patch

Ojan Vafai

Comment 13 2012-06-01 16:07:47 PDT

Comment on attachment 145398 [details] Patch This patch depends on the one in bug 88116.

Gustavo Noronha (kov)

Comment 14 2012-06-01 16:18:23 PDT

Comment on attachment 145398 [details] Patch Attachment 145398 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12863678

Early Warning System Bot

Comment 15 2012-06-01 16:18:32 PDT

Comment on attachment 145398 [details] Patch Attachment 145398 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12872581

Early Warning System Bot

Comment 16 2012-06-01 16:23:21 PDT

Comment on attachment 145398 [details] Patch Attachment 145398 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12869636

Build Bot

Comment 17 2012-06-01 16:28:14 PDT

Comment on attachment 145398 [details] Patch Attachment 145398 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12868664

Build Bot

Comment 18 2012-06-01 16:37:10 PDT

Comment on attachment 145398 [details] Patch Attachment 145398 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12860823

Gyuyoung Kim

Comment 19 2012-06-01 16:45:07 PDT

Comment on attachment 145398 [details] Patch Attachment 145398 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12888105

WebKit Review Bot

Comment 20 2012-06-01 20:53:15 PDT

Comment on attachment 145398 [details] Patch Attachment 145398 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12888139

Ojan Vafai

Comment 21 2012-06-05 11:43:12 PDT

Created attachment 145848 [details] Patch

Julien Chaffraix

Comment 22 2012-06-05 12:47:45 PDT

Comment on attachment 145848 [details] Patch r=me assuming the tests are passing.

WebKit Review Bot

Comment 23 2012-06-05 22:42:07 PDT

Comment on attachment 145848 [details] Patch Clearing flags on attachment: 145848 Committed r119562: <http://trac.webkit.org/changeset/119562>

WebKit Review Bot

Comment 24 2012-06-05 22:42:15 PDT

All reviewed patches have been landed. Closing bug.

Victor Carbune

Comment 25 2012-06-08 02:46:21 PDT

The initial html page attached still isn't rendered at all properly, but I guess there are other related bugs filed?

Tony Chang

Comment 26 2012-06-08 11:24:47 PDT

Created attachment 146615 [details] reduction Here's a new reduction. This doesn't seem to be specific to flexbox, but with vertical writing mode. A few comments: - If you remove #middle, the text no longer overflows. - If you keep #middle and set the height to 300px, the text no longer overflows. - If you keep #middle and set the height to 100%, the text overflow. It seems like setting the height of #middle to 100% should work.

Tony Chang

Comment 27 2012-06-08 11:29:18 PDT

Focusing the reduction.

Ojan Vafai

Comment 28 2012-08-09 14:22:20 PDT

This bug has too much noise with the flexbox patch in it. Moving over to bug 93655 to focus on the remaining writing-mode issue.

Note You need to log in before you can comment on or make changes to this bug.