Bug 87176

Summary: [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
patch none

Xianzhu Wang
Reported 2012-05-22 15:57:17 PDT
For now both DumpRenderTree.gypi and DumpRenderTree.gyp contain conditions about DumpRenderTree sources. I think we should move all conditions into DumpRenderTree.gyp. Some conditions in DumpRenderTree.gypi (e.g. the ones about win and mac) are also redundant and should be removed.
Attachments
patch (3.46 KB, patch)
2012-05-22 16:19 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-05-22 16:19:07 PDT
Created attachment 143391 [details] patch
WebKit Review Bot
Comment 2 2012-05-22 17:20:22 PDT
Comment on attachment 143391 [details] patch Clearing flags on attachment: 143391 Committed r118085: <http://trac.webkit.org/changeset/118085>
WebKit Review Bot
Comment 3 2012-05-22 17:20:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.