Bug 86862

Summary: [Chromium-Android] Run DumpRenderTree as an apk
Product: WebKit Reporter: Xianzhu Wang <wangxianzhu>
Component: Tools / TestsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, jnd, ojan, tkent, tony, webkit.review.bot, zhenghao
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86922, 86923, 87196    
Bug Blocks: 66687    
Attachments:
Description Flags
patch
none
patch v2 none

Xianzhu Wang
Reported 2012-05-18 09:26:24 PDT
On Android, some features (e.g. media player) are implemented through Java API, so DumpRenderTree need to provide a Java environment so that the tests depending on those features can pass.
Attachments
patch (63.79 KB, patch)
2012-05-18 15:38 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
patch v2 (63.79 KB, patch)
2012-05-18 15:50 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-05-18 15:38:59 PDT
Created attachment 142797 [details] patch
WebKit Review Bot
Comment 2 2012-05-18 15:42:23 PDT
Attachment 142797 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/D..." exit_code: 1 Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Xianzhu Wang
Comment 3 2012-05-18 15:50:17 PDT
Created attachment 142806 [details] patch v2
Tony Chang
Comment 4 2012-05-18 16:12:39 PDT
This patch is gigantic. Can we split off the C++ & gyp changes from the python changes? Can the python changes be split into multiple patches?
Xianzhu Wang
Comment 5 2012-05-18 16:40:11 PDT
(In reply to comment #4) > This patch is gigantic. Can we split off the C++ & gyp changes from the python changes? Can the python changes be split into multiple patches? I'll split it into two parts (bug 86922 and bug 86923). It's difficult to split the python part.
Note You need to log in before you can comment on or make changes to this bug.