Bug 86040

Summary: [Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, jnd, johnme, peter, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-05-09 17:08:23 PDT
[Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
Attachments
Patch (3.21 KB, patch)
2012-05-09 17:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-05-09 17:08:54 PDT
Created attachment 141057 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-09 17:13:16 PDT
Comment on attachment 141057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141057&action=review > Tools/DumpRenderTree/chromium/TestShell.cpp:710 > +#if OS(ANDROID) > + webkit_support::EncodeRGBAPNGWithChecksum(reinterpret_cast<const unsigned char*>(sourceBitmap.getPixels()), sourceBitmap.width(), > + sourceBitmap.height(), static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, md5hash, &png); > +#else > webkit_support::EncodeBGRAPNGWithChecksum(reinterpret_cast<const unsigned char*>(sourceBitmap.getPixels()), sourceBitmap.width(), > sourceBitmap.height(), static_cast<int>(sourceBitmap.rowBytes()), discardTransparency, md5hash, &png); > +#endif Did you just add 5 lines of code, or 4 charaters or am blind?
Kent Tamura
Comment 3 2012-05-09 17:28:58 PDT
Comment on attachment 141057 [details] Patch This bug looks a dupe of Bug 84682. Anyway, the code is ok.
Adam Barth
Comment 4 2012-05-09 17:30:24 PDT
*** Bug 84682 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 5 2012-05-09 17:50:30 PDT
Comment on attachment 141057 [details] Patch Clearing flags on attachment: 141057 Committed r116588: <http://trac.webkit.org/changeset/116588>
WebKit Review Bot
Comment 6 2012-05-09 17:50:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.