Bug 85049

Summary: Rename deviceDPI to devicePixelRatio
Product: WebKit Reporter: Alexander Færøy <ahf>
Component: WebKit QtAssignee: Alexander Færøy <ahf>
Status: RESOLVED FIXED    
Severity: Normal CC: jesus, kenneth, kpiascik, menard, mlattanzio, ossy, tonikitoo, webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70236    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexander Færøy
Reported 2012-04-27 04:25:50 PDT
SSIA.
Attachments
Patch (10.88 KB, patch)
2012-05-02 05:44 PDT, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
Patch (10.90 KB, patch)
2012-05-02 06:47 PDT, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2012-05-03 03:22 PDT, Alexander Færøy 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexander Færøy
Comment 1 2012-05-02 05:44:10 PDT
Created attachment 139794 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-05-02 05:46:21 PDT
Comment on attachment 139794 [details] Patch In the future lets add documentation
Konrad Piascik
Comment 3 2012-05-02 06:04:16 PDT
Comment on attachment 139794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139794&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:893 > + ViewportAttributes attr = computeViewportAttributes(m_page->viewportArguments(), minimumLayoutFallbackWidth, settings->deviceWidth(), settings->deviceHeight(), 160 * settings->devicePixelRatio(), m_viewportSize); How is this correct? devicePixelRatio is supposed to be a double, but device DPI is an int. These are 2 different properties aren't they? You can't pass devicePixelRatio into the deviceDPI value for computeViewportAttributers.
Jesus Sanchez-Palencia
Comment 4 2012-05-02 06:06:35 PDT
(In reply to comment #2) > (From update of attachment 139794 [details]) > In the future lets add documentation <nitpicking> I think the bug title here is a bit misleading on a first glance since this patch is more about adding the experimental API than actually refactoring that piece of code. 2 cents for the future ;) </nitpicking>
Alexander Færøy
Comment 5 2012-05-02 06:47:09 PDT
Created attachment 139803 [details] Patch
Alexander Færøy
Comment 6 2012-05-03 01:55:36 PDT
Committed r115948: <http://trac.webkit.org/changeset/115948>
Csaba Osztrogonác
Comment 7 2012-05-03 02:41:20 PDT
Reopen, because it broke an API test on Qt5-WK2: FAIL! : tst_QQuickWebView::scrollRequest() 'webView()->contentY() == y' returned FALSE. () Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp(400)] Could you check and fix it?
Alexander Færøy
Comment 8 2012-05-03 03:22:40 PDT
Created attachment 139979 [details] Patch
Alexander Færøy
Comment 9 2012-05-03 03:50:09 PDT
Committed r115955: <http://trac.webkit.org/changeset/115955>
Note You need to log in before you can comment on or make changes to this bug.