Bug 83787

Summary:	REGRESSION (r113910-113934): GMail displays a misplaced and dysfunctional Inbox Settings menu
Product:	WebKit	Reporter:	R. Kevin Hill <rkevinhill>
Component:	JavaScriptCore	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Critical	CC:	ap, arv, fpizlo, koivisto, levin
Priority:	P1	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	Mac (Intel)
OS:	OS X 10.7
Bug Depends on:	81588
Bug Blocks:

R. Kevin Hill

Reported 2012-04-12 08:30:58 PDT

Returns Inbox display to "invitation to new inbox" mode ("Try out all of the new inbox styles" etc.), none of the links of which work; "Settings" button does not work. Previous Webkits and current Safari do not do this. Not a programmer; my first bug report, guessing about the component.

Attachments
Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2012-04-12 14:09:09 PDT

Steps to reproduce: just log in to GMail. There are many JSC changes in this range, and one CSS change. Starting with JSC.

Alexey Proskuryakov

Comment 2 2012-04-12 14:09:25 PDT

<rdar://problem/11239404>

Antti Koivisto

Comment 3 2012-04-12 18:03:48 PDT

Does it occur in Chromium? That should help identifying if this is a CSS or JSC problem.

Filip Pizlo

Comment 4 2012-04-12 18:06:23 PDT

(In reply to comment #3) > Does it occur in Chromium? That should help identifying if this is a CSS or JSC problem. It appears to not be your patch! I just checked that by merging your patch over r113909 and gmail still works. On the other hand, disabling all JSC optimizations doesn't fix it, either. So it's not clear who's at fault. :-/

Filip Pizlo

Comment 5 2012-04-13 12:27:15 PDT

This was caused by https://bugs.webkit.org/show_bug.cgi?id=81573 http://trac.webkit.org/changeset/113931

Erik Arvidsson

Comment 6 2012-04-13 12:31:01 PDT

This is a bug in JSC. JSC does not support ES5 Array.prototype.toString correctly.

Filip Pizlo

Comment 7 2012-04-13 17:32:58 PDT

Verifying whether this is fixed now.

David Levin

Comment 8 2012-04-14 20:51:46 PDT

This was broken in Chromium as well. The breaking change was rolled out here: http://trac.webkit.org/changeset/114200

Alexey Proskuryakov

Comment 9 2012-04-15 00:06:05 PDT

Marking fixed per the above comment (I also verified that it doesn't fail for me with r114211).

Note You need to log in before you can comment on or make changes to this bug.