Bug 75998

Created attachment 121919 [details] Patch

Created attachment 121920 [details] Patch

Comment on attachment 121920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121920&action=review For completeness, you may want to consider looking into using LayoutTests/fast/js/resources/js-test-{pre, post}.js, which provide convenience functions for writing PASS/FAIL tests. > LayoutTests/css3/calc/line-height-expected.txt:3 > +The line height of these lines should be identical > +The line height of these lines should be identical > +The line height of these lines should be identical I suggest that we omit this text when the test is run using DRT so as to make the expected results straight forward to interpret for PASS/FAIL. An example of a test case that omits such support text when run using DRT is <http://trac.webkit.org/browser/trunk/LayoutTests/fast/css/button-height.html>. Notice, when button-height.html is run in DRT (i.e. window.layoutTestController exists) it removes the element with id "test-container", which contains the test text/support structures. > LayoutTests/css3/calc/line-height-expected.txt:5 > +FAIL > +Computed line heights do not match: 32px, normal, normal I suggest concatenating these two lines such that line 4 prefixes line 5 since line 5 describes the failure alluded to by line 4. > LayoutTests/css3/calc/line-height.html:27 > + if (heights.length != 0) Nit: I would write this as: if (heights.length) ...

Created attachment 121974 [details] Patch

Hi Daniel - thanks for the review. I've rewritten the test to use js-test-{pre, post}.

Comment on attachment 121974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121974&action=review Thanks Mike for the updated patch! This looks good. I have some minor nits. > LayoutTests/css3/calc/line-height.html:4 > + span { font-size: 16px;} Nit: The spacing in this line is inconsistent with the spacing used in the lines below. In particular, the curly braces on this line aren't aligned with the curly braces of subsequent lines. I prefer a single space between the identifier and the '{'. Regardless, I suggest that we choose a notation and stick with it so as to be consistent. > LayoutTests/css3/calc/line-height.html:18 > + if (window.layoutTestController) > + layoutTestController.dumpAsText(); Nit: This is unnecessary by line 2 of LayoutTests/fast/js/resources/js-test-pre.js, <http://trac.webkit.org/browser/trunk/LayoutTests/fast/js/resources/js-test-pre.js?rev=102918#L2>.

Created attachment 122102 [details] Patch for landing

Comment on attachment 121974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121974&action=review >> LayoutTests/css3/calc/line-height.html:4 >> + span { font-size: 16px;} > > Nit: The spacing in this line is inconsistent with the spacing used in the lines below. In particular, the curly braces on this line aren't aligned with the curly braces of subsequent lines. I prefer a single space between the identifier and the '{'. Regardless, I suggest that we choose a notation and stick with it so as to be consistent. Done. >> LayoutTests/css3/calc/line-height.html:18 >> + layoutTestController.dumpAsText(); > > Nit: This is unnecessary by line 2 of LayoutTests/fast/js/resources/js-test-pre.js, <http://trac.webkit.org/browser/trunk/LayoutTests/fast/js/resources/js-test-pre.js?rev=102918#L2>. Done.

Comment on attachment 122102 [details] Patch for landing Clearing flags on attachment: 122102 Committed r104752: <http://trac.webkit.org/changeset/104752>

All reviewed patches have been landed. Closing bug.