Bug 75486

Summary:

NRWT fails to launch Apple's Windows port of DumpRenderTree/WebKitTestRunner

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, eric, ojan, webkit-bug-importer

Priority:

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Bug Depends on:

Bug Blocks:

38756

Attachments:

Description	Flags
Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code	sfalken: review+
Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code	sfalken: review+

Adam Roben (:aroben)

Reported 2012-01-03 12:37:45 PST

To reproduce: 1. new-run-webkit-tests All tests "crash". In fact DRT is failing to launch.

Attachments
Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code (30.00 KB, patch) 2012-01-05 08:00 PST, Adam Roben (:aroben)	sfalken: review+	Details Formatted Diff Diff
Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code (26.75 KB, patch) 2012-01-05 08:13 PST, Adam Roben (:aroben)	sfalken: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2012-01-03 12:38:12 PST

<rdar://problem/10638124>

Adam Roben (:aroben)

Comment 2 2012-01-03 12:39:51 PST

Looks like we need to set PATH correctly, like ORWT does. There's even a comment about this in port/win.py!

Adam Roben (:aroben)

Comment 3 2012-01-03 13:04:35 PST

I think we'll also need a way to read strings from the registry, and to convert from Windows paths to Cygwin paths. (webkitpy.common.system.path.cygpath goes in the other direction.)

Adam Roben (:aroben)

Comment 4 2012-01-04 06:53:21 PST

Maybe it would be better to fix this by making DRT/WTR not require any special PATH munging at all, like we plan to do for MiniBrowser (bug 68576) and WinLauncher (bug 68578).

Dirk Pranke

Comment 5 2012-01-04 13:10:40 PST

(In reply to comment #3) > I think we'll also need a way to read strings from the registry, and to convert from Windows paths to Cygwin paths. (webkitpy.common.system.path.cygpath goes in the other direction.) Can we get this w/ path._winpath_to_uri and then strip off the 'file:///', or do we need more cygpath magic?

Adam Roben (:aroben)

Comment 6 2012-01-04 13:33:48 PST

(In reply to comment #5) > (In reply to comment #3) > > I think we'll also need a way to read strings from the registry, and to convert from Windows paths to Cygwin paths. (webkitpy.common.system.path.cygpath goes in the other direction.) > > Can we get this w/ path._winpath_to_uri and then strip off the 'file:///', or do we need more cygpath magic? We need more cygpath magic. We need to turn something like this: C:\Program Files (x86)\Common Files\Apple\Apple Application Support into this: /cygdrive/c/Program Files (x86)/Common Files/Apple/Apple Application Support But I'm going to make DRT/WTR not require all this PATH magic, which will mean we won't need a way to read from the registry or convert to Cygwin paths at all.

Adam Roben (:aroben)

Comment 7 2012-01-05 07:17:58 PST

This affects WebKitTestRunner too.

Adam Roben (:aroben)

Comment 8 2012-01-05 08:00:35 PST

Created attachment 121277 [details] Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code

Adam Roben (:aroben)

Comment 9 2012-01-05 08:13:37 PST

Created attachment 121281 [details] Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code

Eric Seidel (no email)

Comment 10 2012-01-05 10:10:28 PST

Thanks adam. :)

Adam Roben (:aroben)

Comment 11 2012-01-05 11:57:57 PST

Committed r104188: <http://trac.webkit.org/changeset/104188>

Note You need to log in before you can comment on or make changes to this bug.