Bug 74175

Summary: [Refactoring] In prepare-ChangeLog, move top-level code to generate change-log lists into a method
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: Tools / TestsAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, ddkilzer, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73531    
Attachments:
Description Flags
Patch
none
rebased patch for commit none

Kentaro Hara
Reported 2011-12-09 02:54:04 PST
The objective is to make prepare-ChangeLog a loadable Perl module for unit testing. This requires to remove top-level code. This is one of the incremental refactorings for that.
Attachments
Patch (6.31 KB, patch)
2011-12-09 03:07 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (6.26 KB, patch)
2011-12-10 03:09 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-09 03:07:07 PST
Created attachment 118555 [details] Patch
Kentaro Hara
Comment 2 2011-12-09 03:10:37 PST
rniwa: Thanks. I'll stop refactoring today, since further refactoring requires all previous patches to be landed.
David Kilzer (:ddkilzer)
Comment 3 2011-12-09 16:53:34 PST
(In reply to comment #1) > Created an attachment (id=118555) [details] > Patch This looks like a great first step. Thanks!
Ryosuke Niwa
Comment 4 2011-12-09 16:54:32 PST
(In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=118555) [details] [details] > > Patch > > This looks like a great first step. Thanks! Indeed! haraken++
Kentaro Hara
Comment 5 2011-12-10 03:09:32 PST
Created attachment 118688 [details] rebased patch for commit
Kentaro Hara
Comment 6 2011-12-10 03:12:28 PST
rniwa: Oops, I forgot to add the --no-review --no-obsolete option for uploading the rebased patch. Would you r+ again please?
WebKit Review Bot
Comment 7 2011-12-10 22:32:21 PST
Comment on attachment 118688 [details] rebased patch for commit Clearing flags on attachment: 118688 Committed r102536: <http://trac.webkit.org/changeset/102536>
WebKit Review Bot
Comment 8 2011-12-10 22:32:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.