Bug 68578

Summary: WinLauncher fails to launch when double-clicked
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sfalken, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 68576    
Attachments:
Description Flags
Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code andersca: review+

Adam Roben (:aroben)
Reported 2011-09-21 15:26:05 PDT
To reproduce: 1. Double-click WinLauncher.exe It doesn't launch. It complains about not being able to find CFNetwork.dll.
Attachments
Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code (36.55 KB, patch)
2012-01-04 11:24 PST, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-09-21 15:26:39 PDT
<rdar://problem/10163861>
Adam Roben (:aroben)
Comment 2 2011-09-21 15:34:14 PDT
I wonder if we're going to have to split WinLauncher into a .exe launcher that sets up the DLL search path and a .dll that contains the real code.
Adam Roben (:aroben)
Comment 3 2012-01-04 11:24:21 PST
Created attachment 121128 [details] Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
WebKit Review Bot
Comment 4 2012-01-04 11:27:59 PST
Attachment 121128 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1 Tools/win/DLLLauncher/DLLLauncherMain.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Tools/WinLauncher/WinLauncherLauncherResource.h:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Tools/WinLauncher/WinLauncherLauncherResource.h:1: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 22 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 5 2012-01-04 11:29:20 PST
Comment on attachment 121128 [details] Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code View in context: https://bugs.webkit.org/attachment.cgi?id=121128&action=review >>> Tools/WinLauncher/WinLauncherLauncherResource.h:1 >>> +//{{NO_DEPENDENCIES}} >> >> One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] > > Should have a space between // and comment [whitespace/comments] [4] This file is auto-generated by VS. >> Tools/win/DLLLauncher/DLLLauncherMain.cpp:33 >> +#include <string> > > Alphabetical sorting problem. [build/include_order] [4] I'm not sure what our standard style is for headers like <string>. I guess I'll sort them normally.
Adam Roben (:aroben)
Comment 6 2012-01-05 06:53:14 PST
Committed r104153: <http://trac.webkit.org/changeset/104153>
Note You need to log in before you can comment on or make changes to this bug.