Bug 68315
| Summary: | [Qt][WK2] fast/events/media-element-focus-tab.html fails | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bpwv64, ossy, tonikitoo |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 56485 | ||
| Bug Blocks: | |||
Csaba Osztrogonác
fast/events/media-element-focus-tab.html introduced in http://trac.webkit.org/changeset/95381,
but fails on Qt-WK2 platform:
--- /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/fast/events/media-element-focus-tab-expected.txt
+++ /ramdisk/qt-linux-32-release-webkit2/build/layout-test-results/fast/events/media-element-focus-tab-actual.txt
@@ -1,9 +1,9 @@
This tests that a media element ie: <Audio> or <video>, without tabindex can be selected with keyboard (TAB Key)
-SUCCESS: Tab-Key did tab to the Media Element (video1). TEST: WithTabIndexVideo.
-SUCCESS: Tab-Key did tab to the Media Element (video2). TEST: WithoutTabIndexVideo.
-SUCCESS: Tab-Key did tab to the Media Element (video3). TEST: WithoutControlsButWithTabIndexVideo.
-SUCCESS: Tab-Key did tab to the Media Element (audio1). TEST: WithoutTabIndexAudio.
+FAIL: Tab-Key did not tab to the Media Element (video1). TEST: WithTabIndexVideo.
+FAIL: Tab-Key did not tab to the Media Element (video2). TEST: WithoutTabIndexVideo.
+FAIL: Tab-Key did not tab to the Media Element (video3). TEST: WithoutControlsButWithTabIndexVideo.
+FAIL: Tab-Key did not tab to the Media Element (audio1). TEST: WithoutTabIndexAudio.
SUCCESS: Tab-Key did not tab to the Media Element (audio2). TEST: WithoutControlaAndTabIndexAudio.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
Skipped by http://trac.webkit.org/changeset/95384
Deepak Sherveghar
Thanks for skipping the test.
The Media test media-element-focus-tab.html uses "eventSender.keyDown('\t');" to simulate a 'TAB' Key. From the following BUG it seems EventSender functionality for key-down in QT webkit2 is still under development.
https://bugs.webkit.org/show_bug.cgi?id=56485
Bug 56485 : [Qt] Implement KeyDown function for WebKit2 EventSender.
Once 56485 is committed, media-element-focus-tab.html layouttest should work just fine. Till then I guess marking it as skipped makes sense.
Antonio Gomes
(In reply to comment #2)
> Thanks for skipping the test.
>
> The Media test media-element-focus-tab.html uses "eventSender.keyDown('\t');" to simulate a 'TAB' Key. From the following BUG it seems EventSender functionality for key-down in QT webkit2 is still under development.
>
> https://bugs.webkit.org/show_bug.cgi?id=56485
> Bug 56485 : [Qt] Implement KeyDown function for WebKit2 EventSender.
>
> Once 56485 is committed, media-element-focus-tab.html layouttest should work just fine. Till then I guess marking it as skipped makes sense.
Ossy, would you mind to re-test it, when you get a idle cycle? :) Thanks
Jocelyn Turcotte
=== Bulk closing of Qt bugs ===
If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.
If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.