Bug 68117

Summary: convertToLayerCoords on a position: fixed layer should take transforms into account
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: NEW    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 31278    
Attachments:
Description Flags
Proposed fix 1: Pass true as useTransform and account for our layer's translation to avoid breaking the rest of the code.
none
Proposed fix 1.1: Updated bug & ChangeLog. none

Julien Chaffraix
Reported 2011-09-14 14:13:27 PDT
As mentioned in bug 31278, currently convertToLayerCoords is ignoring transforms when calling localToAbsolute which looks wrong. This bug aims at removing this limitation.
Attachments
Proposed fix 1: Pass true as useTransform and account for our layer's translation to avoid breaking the rest of the code. (28.28 KB, patch)
2011-09-14 14:44 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Proposed fix 1.1: Updated bug & ChangeLog. (28.47 KB, patch)
2011-09-14 15:50 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-09-14 14:44:34 PDT
Created attachment 107396 [details] Proposed fix 1: Pass true as useTransform and account for our layer's translation to avoid breaking the rest of the code.
Simon Fraser (smfr)
Comment 2 2011-09-14 14:50:56 PDT
Comment on attachment 107396 [details] Proposed fix 1: Pass true as useTransform and account for our layer's translation to avoid breaking the rest of the code. Looks like this patch only affects position:fixed elements. The bug title and change log should be updated to reflect this.
Julien Chaffraix
Comment 3 2011-09-14 15:50:50 PDT
Created attachment 107414 [details] Proposed fix 1.1: Updated bug & ChangeLog.
Julien Chaffraix
Comment 4 2011-09-15 12:04:10 PDT
Comment on attachment 107414 [details] Proposed fix 1.1: Updated bug & ChangeLog. Let's forget about this patch, the scope is not right: my understanding is that the rest of the code is still assuming that transforms are not taken into account in convertToLayer and it seems fragile to just patch one code path.
Note You need to log in before you can comment on or make changes to this bug.