Bug 67859

Created attachment 106891 [details] Patch

Comment on attachment 106891 [details] Patch Not for review. Here to monitor progress.

Attachment 106891 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/WebViewImpl.cpp:1022: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/WebViewImpl.cpp:1027: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:643: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WebKit/chromium/src/ChromeClientImpl.cpp:647: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:648: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:649: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:674: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebKit/chromium/src/ChromeClientImpl.cpp:676: Should have a space between // and comment [whitespace/comments] [4] Source/WebKit/chromium/src/ChromeClientImpl.h:128: The parameter name "arguments" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/chromium/public/WebViewClient.h:123: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebKit/chromium/public/WebViewClient.h:124: One space before end of line comments [whitespace/comments] [5] Source/WebKit/chromium/public/WebViewClient.h:128: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 12 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 106891 [details] Patch Attachment 106891 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9621943

See also https://bugs.webkit.org/show_bug.cgi?id=67616

Comment on attachment 106891 [details] Patch Attachment 106891 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9631102

This has been replaced by the master bug: https://bugs.webkit.org/show_bug.cgi?id=70559 Marking this as a Duplicate. (In reply to comment #6) > (From update of attachment 106891 [details]) > Attachment 106891 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/9631102 *** This bug has been marked as a duplicate of bug 70559 ***