Bug 64852

Summary: [Chromium] Turn on new WebSocket protocol in worker shadow page
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: WebCore Misc.Assignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dimich, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 50099    
Attachments:
Description Flags
Patch
none
Patch v2 (add FIXME comment)
none
Patch for landing none

Yuta Kitamura
Reported 2011-07-20 01:12:10 PDT
I'm trying to turn on the new WebSocket protocol by default. This should be done in the following steps: (1) Change the default preference value in webkit/glue/webpreferences.{h,cc} (in Chromium tree). (2) Change the default preference value in worker shadow page initialized in WebWorkerBase::initializeLoader() (in WebKit tree). This bug takes care of step (2). Step (2) is required to enable the new protocol in WebSocket objects initialized in worker context, because they live in worker loader context and look at the value of a Settings flag of the shadow page.
Attachments
Patch (1.57 KB, patch)
2011-07-20 05:48 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Patch v2 (add FIXME comment) (1.84 KB, patch)
2011-07-22 06:06 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.96 KB, patch)
2011-07-23 06:40 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-07-20 05:45:33 PDT
A patch for step (1) is under review at <http://codereview.chromium.org/7462009/>.
Yuta Kitamura
Comment 2 2011-07-20 05:48:09 PDT
Created attachment 101454 [details] Patch
Yuta Kitamura
Comment 3 2011-07-20 05:48:54 PDT
Comment on attachment 101454 [details] Patch Setting CQ- since this patch should be committed after <http://codereview.chromium.org/7462009/>.
Yuta Kitamura
Comment 4 2011-07-20 05:54:07 PDT
Dmitry, could you take a look at this patch? I think it's better to copy the value of Settings::useHixie76WebSocketProtocol() of the main thread (rather than setting a constant "false"), but I could not figure out a good way to do this.
Kent Tamura
Comment 5 2011-07-21 23:00:46 PDT
(In reply to comment #4) > Dmitry, could you take a look at this patch? > > I think it's better to copy the value of Settings::useHixie76WebSocketProtocol() of the main thread (rather than setting a constant "false"), but I could not figure out a good way to do this. Though I don't know how to retrieve the value from the main thread, I think we need a FIXME comment.
Yuta Kitamura
Comment 6 2011-07-22 06:06:59 PDT
Created attachment 101723 [details] Patch v2 (add FIXME comment)
Dmitry Titov
Comment 7 2011-07-22 14:36:03 PDT
Comment on attachment 101723 [details] Patch v2 (add FIXME comment) View in context: https://bugs.webkit.org/attachment.cgi?id=101723&action=review r=me with a note. > Source/WebKit/chromium/src/WebWorkerBase.cpp:242 > + // FIXME: Should copy the value of Settings::hixie76ProtocolEnabled() of a view in the main thread. This code is running in the main WebKit thread, but it runs in a sandboxed Worker process. Settings information should be passed to the Worker process from Browser process when the worker is created (similar to RenderThread::OnCreateNewView). Could you please change the comment to reflect this?
Yuta Kitamura
Comment 8 2011-07-23 06:40:53 PDT
Created attachment 101809 [details] Patch for landing
Yuta Kitamura
Comment 9 2011-07-23 06:42:56 PDT
Comment on attachment 101723 [details] Patch v2 (add FIXME comment) View in context: https://bugs.webkit.org/attachment.cgi?id=101723&action=review Thank you for your review! >> Source/WebKit/chromium/src/WebWorkerBase.cpp:242 >> + // FIXME: Should copy the value of Settings::hixie76ProtocolEnabled() of a view in the main thread. > > This code is running in the main WebKit thread, but it runs in a sandboxed Worker process. Settings information should be passed to the Worker process from Browser process when the worker is created (similar to RenderThread::OnCreateNewView). Could you please change the comment to reflect this? Updated the comment as per your suggestion.
WebKit Review Bot
Comment 10 2011-07-23 07:55:07 PDT
Comment on attachment 101809 [details] Patch for landing Clearing flags on attachment: 101809 Committed r91634: <http://trac.webkit.org/changeset/91634>
WebKit Review Bot
Comment 11 2011-07-23 07:55:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.