Bug 63632

Summary:

[CSS Regions] Add support for skipped tests

Product:

WebKit

Reporter:

Mihnea Ovidenie <mihnea>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

stearns, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

57312

Attachments:

Description	Flags
Patch	none
Add testcase to populate path to skip	tony: review-
Changed testfile on feedback in Comment 6	none

Mihnea Ovidenie

Reported 2011-06-29 08:46:20 PDT

The LayoutTests for CSSRegions will be placed in LayoutTests/fast/regions. For now, these tests will be skipped as the CSSRegions support is not enabled by default. I will modify the following files to avoid those tests being run. LayoutTests/platform/gtk/Skipped LayoutTests/platform/mac/Skipped LayoutTests/platform/qt/Skipped LayoutTests/platform/win/Skipped LayoutTests/platform/chromium/test_expectations.txt

Attachments
Patch (3.51 KB, patch) 2011-06-29 09:08 PDT, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Add testcase to populate path to skip (5.05 KB, patch) 2011-06-29 15:40 PDT, Alan Stearns	tony: review-	Details Formatted Diff Diff
Changed testfile on feedback in Comment 6 (5.04 KB, patch) 2011-06-29 16:22 PDT, Alan Stearns	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mihnea Ovidenie

Comment 1 2011-06-29 09:08:16 PDT

Created attachment 99096 [details] Patch

WebKit Review Bot

Comment 2 2011-06-29 09:10:43 PDT

Attachment 99096 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/test_expectations.txt:3934: Path does not exist. fast/regions [test/expectations] [2] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mihnea Ovidenie

Comment 3 2011-06-29 09:21:30 PDT

The path LayoutTests/fast/regions does not exits for the moment. I wanted to add this patch so that i will further minimize the chance to get merge conflict for further CSSRegions patches.

Tony Chang

Comment 4 2011-06-29 11:43:32 PDT

(In reply to comment #3) > The path LayoutTests/fast/regions does not exits for the moment. I wanted to add this patch so that i will further minimize the chance to get merge conflict for further CSSRegions patches. Can you just add in the patch where you add the new test? One way to avoid merge conflicts is to not put the new lines at the bottom of the Skipped/test_expectations.txt files.

Alan Stearns

Comment 5 2011-06-29 15:40:44 PDT

Created attachment 99163 [details] Add testcase to populate path to skip

Tony Chang

Comment 6 2011-06-29 16:09:08 PDT

Comment on attachment 99163 [details] Add testcase to populate path to skip View in context: https://bugs.webkit.org/attachment.cgi?id=99163&action=review Some minor nits to the test file. > LayoutTests/fast/regions/flow-content-basic.html:1 > +<head> <!DOCTYPE HTML> > LayoutTests/fast/regions/flow-content-basic.html:6 > +  This indenting looks weird, maybe some tabs snuck in? Also 'this test' -> 'This test' and end the last sentence with a period. > LayoutTests/fast/regions/flow-content-basic.html:26 > +<body onload="runTests();"> This onload doesn't look used.

Alan Stearns

Comment 7 2011-06-29 16:22:44 PDT

Created attachment 99175 [details] Changed testfile on feedback in Comment 6

Tony Chang

Comment 8 2011-06-29 16:43:54 PDT

BTW, you may want to come up with ways to make the tests non-pixel tests (i.e., using layoutTestController.dumpAsText() or dump-as-markup.js). This allows us to have a single cross-platform result.

Tony Chang

Comment 9 2011-06-29 16:44:27 PDT

Of course, this test can be in changed in the patch that lands the code.

Alan Stearns

Comment 10 2011-06-29 16:50:29 PDT

My plan is to mostly rely on DumpRenderTree, since the result that needs to be checked for regions and exclusions is what gets rendered. It would be especially cool if I could get the RenderTree result from the layoutTestController and perform my validation steps in javascript, but I haven't found a way of doing that.

WebKit Review Bot

Comment 11 2011-06-29 16:54:49 PDT

Comment on attachment 99175 [details] Changed testfile on feedback in Comment 6 Clearing flags on attachment: 99175 Committed r90067: <http://trac.webkit.org/changeset/90067>

WebKit Review Bot

Comment 12 2011-06-29 16:54:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.