Bug 60292

Summary: [chromium] Rebaseline needed for video-source-error
Product: WebKit Reporter: Steve Lacey <sjl>
Component: Tools / TestsAssignee: Steve Lacey <sjl>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, eric, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Steve Lacey
Reported 2011-05-05 12:34:09 PDT
As chromium doesn't support mp4, we need to expect an error from 'supported-format-mp4'. I thought about changing the name of this tag to 'maybe-supported-format-mp4', but the churn in expectations didn't seem worth it.
Attachments
Patch (4.70 KB, patch)
2011-05-05 12:36 PDT, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Patch (3.13 KB, patch)
2011-05-05 13:23 PDT, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Patch (3.13 KB, patch)
2011-05-05 15:46 PDT, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Steve Lacey
Comment 1 2011-05-05 12:36:34 PDT
Created attachment 92448 [details] Patch
Eric Carlson
Comment 2 2011-05-05 12:45:49 PDT
Comment on attachment 92448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92448&action=review > LayoutTests/ChangeLog:12 > + * platform/chromium-mac/media/video-source-error-expected.txt: Added. > + * platform/chromium-win/media/video-source-error-expected.txt: Added. These two results files are identical, are you linux results also the same? If so, a single file would be better.
Steve Lacey
Comment 3 2011-05-05 13:23:44 PDT
Created attachment 92459 [details] Patch
Steve Lacey
Comment 4 2011-05-05 13:25:14 PDT
Comment on attachment 92448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92448&action=review >> LayoutTests/ChangeLog:12 >> + * platform/chromium-win/media/video-source-error-expected.txt: Added. > > These two results files are identical, are you linux results also the same? If so, a single file would be better. Indeed they are identical. chromium-linux falls back to chromium-win, so all three are identical and I've moved it into platform/chromium. Looks like I need to go do some more work in the rebaselining tool...
WebKit Commit Bot
Comment 5 2011-05-05 15:39:20 PDT
Comment on attachment 92459 [details] Patch Rejecting attachment 92459 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/media/video-source-error-expected.txt patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 819. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8590030
Steve Lacey
Comment 6 2011-05-05 15:46:04 PDT
Created attachment 92483 [details] Patch
Steve Lacey
Comment 7 2011-05-05 15:46:34 PDT
Fixed conflict.
Steve Lacey
Comment 8 2011-05-06 09:50:20 PDT
Could someone flip the bits before test_expectations changes too much again :-) Thx.
WebKit Commit Bot
Comment 9 2011-05-06 12:06:09 PDT
Comment on attachment 92483 [details] Patch Clearing flags on attachment: 92483 Committed r85965: <http://trac.webkit.org/changeset/85965>
WebKit Commit Bot
Comment 10 2011-05-06 12:06:14 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 11 2011-05-06 12:32:23 PDT
The commit-queue encountered the following flaky tests while processing attachment 92483 [details]: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Eric Seidel (no email)
Comment 12 2011-05-09 21:01:45 PDT
Comment on attachment 92448 [details] Patch Cleared review? from obsolete attachment 92448 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.