Bug 59428

Summary: Enable strict mode for OwnPtr and PassOwnPtr
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, darin, dglazkov, eric, gustavo.noronha, gustavo, levin, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 59666, 59667, 59861, 59876, 59878, 59881, 59898    
Bug Blocks: 59909    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2011-04-25 23:48:45 PDT
Enable strict mode for OwnPtr
Attachments
Patch (1.15 KB, patch)
2011-04-25 23:49 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1020 bytes, patch)
2011-04-27 13:40 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.14 KB, patch)
2011-05-01 17:33 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-04-25 23:49:26 PDT
Created attachment 91073 [details] Patch
David Levin
Comment 2 2011-04-25 23:56:56 PDT
Comment on attachment 91073 [details] Patch pending ews results.
WebKit Review Bot
Comment 3 2011-04-26 00:12:28 PDT
Attachment 91073 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8509542
Early Warning System Bot
Comment 4 2011-04-26 00:19:32 PDT
Attachment 91073 [details] did not build on qt: Build output: http://queues.webkit.org/results/8509543
Build Bot
Comment 5 2011-04-26 00:41:44 PDT
Attachment 91073 [details] did not build on win: Build output: http://queues.webkit.org/results/8506647
WebKit Review Bot
Comment 6 2011-04-26 00:55:45 PDT
Attachment 91073 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8508569
Collabora GTK+ EWS bot
Comment 7 2011-04-26 03:01:40 PDT
Attachment 91073 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8507579
Adam Barth
Comment 8 2011-04-27 13:40:17 PDT
Created attachment 91337 [details] Patch
David Levin
Comment 9 2011-04-27 13:41:34 PDT
Comment on attachment 91337 [details] Patch This will make it easier for other ports to break the mac platform, but I guess it will get fixed quickly and it shouldn't happen too often.
Adam Barth
Comment 10 2011-04-27 13:55:51 PDT
> This will make it easier for other ports to break the mac platform, but I guess it will get fixed quickly and it shouldn't happen too often. Yeah, this is just an intermediate state. We shouldn't linger here very long.
Adam Barth
Comment 11 2011-04-27 13:59:04 PDT
Committed r85084: <http://trac.webkit.org/changeset/85084>
Adam Barth
Comment 12 2011-04-27 14:03:36 PDT
Re-opening because we need to enable this on other platforms.
WebKit Review Bot
Comment 13 2011-04-27 14:19:02 PDT
http://trac.webkit.org/changeset/85084 might have broken Leopard Intel Debug (Build)
Darin Adler
Comment 14 2011-04-27 14:41:49 PDT
We also want to enable the strict mode for PassOwnPtr.
Adam Barth
Comment 15 2011-04-27 14:45:56 PDT
(In reply to comment #14) > We also want to enable the strict mode for PassOwnPtr. Yep. I'm testing compile for that one now.
David Levin
Comment 16 2011-04-27 19:29:28 PDT
Comment on attachment 91337 [details] Patch Clearing r+ since it has been landed (to move out of the list to be committed).
Adam Barth
Comment 17 2011-05-01 17:33:22 PDT
Created attachment 91860 [details] Patch
Adam Barth
Comment 18 2011-05-01 17:33:50 PDT
Committed r85445: <http://trac.webkit.org/changeset/85445>
Adam Barth
Comment 19 2011-05-01 18:02:54 PDT
Comment on attachment 91860 [details] Patch Oh, well technically we didn't do strict PassOwnPtr, but that can be another bug.
Note You need to log in before you can comment on or make changes to this bug.