Bug 59142

Summary: Add more test coverage to fast/url
Product: WebKit Reporter: Chris Weber <chris>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
URL: http://www.lookout.net
Attachments:
Description Flags
A patch adding new test cases to the fast/url test suite
none
Patch
none
Patch none

Chris Weber
Reported 2011-04-21 14:54:20 PDT
Created attachment 90609 [details] A patch adding new test cases to the fast/url test suite Adam Barth asked the public IRI mailing list for more test cases in this suite. - Added new test cases for IDNA2003 - Added new test cases for IDNA2008 - Augmented test cases for port.js, host.js, and path.js
Attachments
A patch adding new test cases to the fast/url test suite (9.63 KB, patch)
2011-04-21 14:54 PDT, Chris Weber 		no flags
DetailsFormatted DiffDiff
Patch (23.11 KB, patch)
2011-04-21 16:10 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (35.55 KB, patch)
2011-04-21 16:48 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-04-21 14:56:35 PDT
Thanks. This patch isn't quite formated the way we like. I'll reformat it for you.
Adam Barth
Comment 2 2011-04-21 14:58:47 PDT
In the future, you can upload patches for review by running the following script: ./Tools/Script/webkit-patch upload (You can also supply the bug number if you want to upload your patch to an existing bug.) That script will generated a ChangeLog entry for you and ask you to fill it out with a description of your patch. The script will also take care of making sure the patch is based in the root directory of the repository.
Adam Barth
Comment 3 2011-04-21 16:10:39 PDT
Created attachment 90624 [details] Patch
Adam Barth
Comment 4 2011-04-21 16:48:00 PDT
Created attachment 90633 [details] Patch
WebKit Commit Bot
Comment 5 2011-04-21 23:44:16 PDT
The commit-queue encountered the following flaky tests while processing attachment 90633 [details]: http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-04-21 23:46:29 PDT
Comment on attachment 90633 [details] Patch Clearing flags on attachment: 90633 Committed r84606: <http://trac.webkit.org/changeset/84606>
WebKit Commit Bot
Comment 7 2011-04-21 23:46:35 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2011-04-22 00:31:24 PDT
http://trac.webkit.org/changeset/84606 might have broken Qt Linux Release The following tests are not passing: fast/url/idna2003.html fast/url/idna2008.html fast/url/path.html
Note You need to log in before you can comment on or make changes to this bug.