Bug 59117

Summary: [Refactoring] ShadowContentElement should be part of dom/
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 56973    
Attachments:
Description Flags
Patch
dglazkov: review-, webkit-ews: commit-queue-
A patch made by git diff
none
Trying to fix windows build dglazkov: review+

Hajime Morrita
Reported 2011-04-21 10:55:19 PDT
Currently it's under html/shadow/, but it should be under dom/ because ShadowRoot is going to work with it.
Attachments
Patch (25.31 KB, patch)
2011-05-16 03:48 PDT, Hajime Morrita 		dglazkov: review-
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
A patch made by git diff (37.38 KB, patch)
2011-05-16 19:21 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Trying to fix windows build (37.96 KB, patch)
2011-05-16 22:11 PDT, Hajime Morrita 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2011-05-16 03:48:27 PDT
Created attachment 93632 [details] Patch
Early Warning System Bot
Comment 2 2011-05-16 04:08:23 PDT
Comment on attachment 93632 [details] Patch Attachment 93632 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8700785
Gyuyoung Kim
Comment 3 2011-05-16 04:14:41 PDT
Comment on attachment 93632 [details] Patch Attachment 93632 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/8699830
Collabora GTK+ EWS bot
Comment 4 2011-05-16 04:23:45 PDT
Comment on attachment 93632 [details] Patch Attachment 93632 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8695961
WebKit Review Bot
Comment 5 2011-05-16 04:28:05 PDT
Comment on attachment 93632 [details] Patch Attachment 93632 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8702038
WebKit Review Bot
Comment 6 2011-05-16 05:34:23 PDT
Comment on attachment 93632 [details] Patch Attachment 93632 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8694992
WebKit Review Bot
Comment 7 2011-05-16 06:06:32 PDT
Comment on attachment 93632 [details] Patch Attachment 93632 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8701726
WebKit Review Bot
Comment 8 2011-05-16 06:41:05 PDT
Comment on attachment 93632 [details] Patch Attachment 93632 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8695986
Dimitri Glazkov (Google)
Comment 9 2011-05-16 08:38:40 PDT
Comment on attachment 93632 [details] Patch Angry mob of bots are forcing me to r- this patch.
Hajime Morrita
Comment 10 2011-05-16 18:20:37 PDT
Hmm. The file renaming seems failed - they saw old ShadowContentElement.h.
Hajime Morrita
Comment 11 2011-05-16 18:27:33 PDT
(In reply to comment #10) > Hmm. The file renaming seems failed - they saw old ShadowContentElement.h. No, the patch was wrong....
Hajime Morrita
Comment 12 2011-05-16 19:21:14 PDT
Created attachment 93729 [details] A patch made by git diff Manually attaching the patch.
Hajime Morrita
Comment 13 2011-05-16 22:11:39 PDT
Created attachment 93737 [details] Trying to fix windows build
Dimitri Glazkov (Google)
Comment 14 2011-05-17 09:01:00 PDT
Comment on attachment 93737 [details] Trying to fix windows build View in context: https://bugs.webkit.org/attachment.cgi?id=93737&action=review > Source/WebCore/dom/Node.h:737 > +inline void Node::forceReattach() It would be a great clean up patch for someone to go and replace all attach/detach uses with this.
Hajime Morrita
Comment 15 2011-05-17 18:19:00 PDT
> It would be a great clean up patch for someone to go and replace all attach/detach uses with this. Feeling same, filed Bug 61011.
Hajime Morrita
Comment 16 2011-05-17 18:48:56 PDT
Committed r86726: <http://trac.webkit.org/changeset/86726>
Note You need to log in before you can comment on or make changes to this bug.