Bug 57326

Summary: Remove a bunch of duplicate code by adding some InlineIterator helper methods
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, mitz, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2011-03-29 03:56:38 PDT
Remove a bunch of duplicate code by adding some InlineIterator helper methods
Attachments
Patch (11.10 KB, patch)
2011-03-29 03:59 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-03-29 03:59:49 PDT
Created attachment 87295 [details] Patch
Ryosuke Niwa
Comment 2 2011-03-29 04:38:04 PDT
Comment on attachment 87295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87295&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1949 > if (!currentCharacterIsWS && previousCharacterIsWS) { > - if (autoWrap && o->style()->breakOnlyAfterWhiteSpace()) { > - lBreak.m_obj = o; > - lBreak.m_pos = pos; > - lBreak.m_nextBreakablePosition = nextBreakable; > - } > + if (autoWrap && o->style()->breakOnlyAfterWhiteSpace()) > + lBreak.moveTo(o, pos, nextBreakable); We should just combine these two if statements.
Eric Seidel (no email)
Comment 3 2011-03-29 04:56:47 PDT
Comment on attachment 87295 [details] Patch Next patch.
WebKit Commit Bot
Comment 4 2011-03-29 06:20:37 PDT
Comment on attachment 87295 [details] Patch Rejecting attachment 87295 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: FAILED at 1683. Hunk #5 FAILED at 1754. Hunk #6 FAILED at 1850. Hunk #7 FAILED at 1889. Hunk #8 FAILED at 1899. Hunk #9 FAILED at 1908. Hunk #10 FAILED at 1945. Hunk #11 FAILED at 2008. Hunk #12 FAILED at 2038. Hunk #13 FAILED at 2055. Hunk #14 FAILED at 2064. 13 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlockLineLayout.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8282306
WebKit Commit Bot
Comment 5 2011-03-29 06:40:47 PDT
Comment on attachment 87295 [details] Patch Rejecting attachment 87295 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: FAILED at 1683. Hunk #5 FAILED at 1754. Hunk #6 FAILED at 1850. Hunk #7 FAILED at 1889. Hunk #8 FAILED at 1899. Hunk #9 FAILED at 1908. Hunk #10 FAILED at 1945. Hunk #11 FAILED at 2008. Hunk #12 FAILED at 2038. Hunk #13 FAILED at 2055. Hunk #14 FAILED at 2064. 13 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlockLineLayout.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8283285
WebKit Commit Bot
Comment 6 2011-03-29 10:41:28 PDT
The commit-queue encountered the following flaky tests while processing attachment 87295 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2011-03-29 10:45:03 PDT
Comment on attachment 87295 [details] Patch Clearing flags on attachment: 87295 Committed r82277: <http://trac.webkit.org/changeset/82277>
WebKit Commit Bot
Comment 8 2011-03-29 10:45:08 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2011-03-29 11:19:25 PDT
http://trac.webkit.org/changeset/82277 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.