Bug 56728

Summary: [CMAKE] Add exception handling when PORT was missing.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, paroga, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2011-03-20 19:17:17 PDT
When using cmake build system, user should choose proper port between Efl or WinCE (now). I believe that cmake system should notify what user should do when PORT was missed.
Attachments
Patch (1.41 KB, patch)
2011-03-20 19:24 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-03-20 19:24:11 PDT
Created attachment 86290 [details] Patch
Lucas De Marchi
Comment 2 2011-03-21 14:40:11 PDT
Comment on attachment 86290 [details] Patch LGTM
Antonio Gomes
Comment 3 2011-03-21 16:42:21 PDT
Comment on attachment 86290 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2011-03-21 20:15:59 PDT
Comment on attachment 86290 [details] Patch Clearing flags on attachment: 86290 Committed r81638: <http://trac.webkit.org/changeset/81638>
WebKit Commit Bot
Comment 5 2011-03-21 20:16:05 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 6 2011-03-21 20:22:49 PDT
The commit-queue encountered the following flaky tests while processing attachment 86290 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.